chore(pnpm): move to pnpm 11.20.0 and drop the setting v11 removed - #77
Merged
Conversation
The pin was 11.0.0 while the 11.x line is at 11.20.0. `onlyBuiltDependencies` is gone from the workspace file: it was removed in pnpm 11 and replaced by `allowBuilds`, which this repository already declares, so the list was carrying no effect while reading as though it did. The comment above the overrides also claimed pnpm ignores the `pnpm` field of package.json "with no warning". It warns, by name and by key. Corrected rather than repeated. Nothing about the artifact changes: the lockfile is unchanged and `dist/` built under 11.20.0 is byte-identical to what 1.0.8 published.
There was a problem hiding this comment.
Pull request overview
Updates pnpm-related repository configuration to align with the org-wide pnpm 11.20.0 pin and to remove workspace settings that pnpm 11 no longer reads, while clarifying commentary about override behavior.
Changes:
- Bump
packageManagerfrompnpm@11.0.0topnpm@11.20.0. - Remove
onlyBuiltDependenciesfrompnpm-workspace.yamland rely onallowBuilds. - Clarify the comment about pnpm 11 ignoring the
pnpmfield inpackage.json(and that pnpm emits a warning).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| pnpm-workspace.yaml | Removes a pnpm 11-removed setting and improves the inline documentation around allowBuilds / overrides. |
| package.json | Updates the pnpm toolchain pin via packageManager (and adjusts the description string encoding). |
The migration script serialized package.json without `ensure_ascii=False`, so the em dash in the description came back as `\u2014`. The parsed value is identical and npm was never going to show anything different, but the file got harder to read for no reason connected to this change.
These documents named the old pin, and one of them named it as a requirement — "pnpm@10.8.1 is required; using a different version may break lockfile resolution". After the migration that instruction sends a reader to the wrong toolchain and contradicts what the repository declares. Only the version string changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of the family-wide pnpm alignment. This repository was already on 11, so the change is small.
What
packageManager:pnpm@11.0.0→pnpm@11.20.0onlyBuiltDependenciesfrompnpm-workspace.yamlallowBuilds, which this repo already declares — the list read as though it still had an effectpnpmfield ofpackage.json"with no warning"On that comment
It warns, explicitly and by key:
The claim came from an earlier note of mine that was never checked against the tool. Corrected here rather than repeated.
Verification
pnpm installunder 11.20.0: lockfile unchanged, supply-chain policy check passes over all 866 entries.dist/built under 11.20.0 is byte-identical to what1.0.8published (diff -ragainst the registry tarball).typecheck,lint,build,size,check:exports,check:published,smoke— all green. 279/279 tests.Scope
Development tooling only. No published artifact changes and no release is warranted.