Repository navigation
Pass secret values as value, and release 0.3.1 - #3
Merged
Merged
Conversation
pulumi-github 6.13 deprecated `plaintext_value` for `value` on Actions and Dependabot secrets, and every run warned once per secret. SECRET_APPS now names the argument each resource takes: `value` for those two, and `plaintext_value` for Codespaces secrets, which have no `value` yet. Neither argument forces a replacement, and resource names are unchanged, so the first run after upgrading updates each secret in place with the same value.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
pulumi-github 6.13 deprecated
plaintext_valueforvalueonActionsSecretandDependabotSecret, so everypulumi upprinted one warning per secret:SECRET_APPSnow maps each app to its resource and the argument that takes the value:actionsActionsSecretvaluedependabotDependabotSecretvaluecodespacesCodespacesSecretplaintext_value(novalueyet, even in 6.15)Effect on an existing stack
ForceNewin the provider, so nothing is recreated.pulumi-github>=6.13.0already coversvalue, which first appeared in 6.13.0.Not in this PR
The
pageswarning on the owner's<owner>.github.iorepository stays: it comes fromignore_changes=["pages"]re-sending the value adopted into the state. Moving Pages toRepositoryPagesis a separate change, due before pulumi-github 7 removes the field.Checked
ruff check,ruff format --check,mypy ghfleet: clean.apply()under Pulumi mocks: Actions and Dependabot secrets receivevalue, Codespaces receivesplaintextValue, and the values stay marked as secrets.