Replace stringsearch with the checkpointable variant - #84
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Drops the old
stringsearch.cand promotesstringsearch_fixed.cin its place, renaming everystringsearch_fixedreference inresults/(includingresults/intermittent/) tostringsearch.The only remaining difference from the original benchmark is
find_stringsbeing a 2-D char array instead of an array of pointers; thefindmepointer global is restored, since the index rewrite turned out to be unnecessary.Verified 12/12 PASS (milp, rockclimb, schematic, schematicO3 at 5/10/50 uF, all result=20) and re-measured the stringsearch rows in
results/*.csv.results/intermittent/numbers are unchanged and will be re-run separately.