Update golang.org/x/mod to support tool directives#160
Update golang.org/x/mod to support tool directives#160mattdowdell wants to merge 1 commit intobwplotka:mainfrom
golang.org/x/mod to support tool directives#160Conversation
|
Sorry for extreme lag! Let's update bingo Go version. There are two separate Go versions to care here:
Our current tests are very naive -- they just use same Go version for both bingo build and usage. However, it's likely what users would do anything (install bingo with same version using Nevertheless, I think we need to stay to the latest and say we only support 2-3 latest Go versions with every bingo release. Help wanted to add clear readme about it and limit the Go version matrix on CI (and update all deps). Thanks! NOTE: we have another reason for failed test on main #162 |
|
this was fixed by #163 |
|
Can you rebase @mattdowdell ? |
|
Ah actually, we did this already in upgrade ;p let's close Thanks anyway! |
|
@bwplotka No problem, thanks for fixing the issue :) |
While attempting to install
trivyviabingoI ran into the following error:It's a fairly straightforward problem: the version of
golang.org/x/modused bybingodoes not recognise thetooldirective introduced in Go 1.24.To fix, we simply update that dependency and all is well again, i.e.
For better or worse, this required updating the Go version for
bingo, and atoolchaindirective got added to thego.modin the process. The Go version is inherited fromgolang.org/x/mod, but the toolchain might be negotiable if 1.24.0 is too modern. Other changes togo.sumcame from runninggo mod tidy.Note
It seems very likely that the CI workflow, when approved, will fail as it uses Go 1.18, 1.19, 1.20 and 1.21. With this change, it seems like we could only reasonably support 1.23 and 1.24, and the incoming 1.25 when released.
I'm happy to make that change too, just let me know if that's the direction you want to take.