Skip to content

Fixed bingo get fails on Windows #155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bwplotka merged 2 commits into from
Nov 5, 2025
Merged

Fixed bingo get fails on Windows #155

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f2a99db
Fixed bingo get fails on Windows
melvinmurvie Nov 7, 2024
d4d44c0
Fixed modfile to be not used after closed
melvinmurvie Jan 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
53 changes: 39 additions & 14 deletions get.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,12 +200,17 @@ func get(ctx context.Context, logger *log.Logger, c getConfig, rawTarget string)
if err != nil {
return errors.Wrapf(err, "found unparsable mod file %v. Uninstall it first via get %v@none or fix it manually.", e, name)
}
defer errcapture.Do(&err, mf.Close, "close")

if mf.DirectPackage() == nil {
dpkg := mf.DirectPackage()

if err := mf.Close(); err != nil {
return errors.Wrapf(err, "unable to close mod file %v", e)
}

if dpkg == nil {
return errors.Wrapf(err, "failed to rename tool %v to %v name; found empty mod file %v; Use full path to install tool again", name, c.rename, e)
}
targets = append(targets, *mf.DirectPackage())
targets = append(targets, *dpkg)
}

for i, t := range targets {
Expand Down Expand Up @@ -260,24 +265,29 @@ func get(ctx context.Context, logger *log.Logger, c getConfig, rawTarget string)
if err != nil {
return errors.Wrapf(err, "found unparsable mod file %v. Uninstall it first via get %v@none or fix it manually.", e, name)
}
defer errcapture.Do(&err, mf.Close, "close")

if mf.DirectPackage() != nil {
if target.Path() != "" && target.Path() != mf.DirectPackage().Path() {
dpkg := mf.DirectPackage()

if err := mf.Close(); err != nil {
return errors.Wrapf(err, "unable to close mod file %v", e)
}

if dpkg != nil {
if target.Path() != "" && target.Path() != dpkg.Path() {
if pathWasSpecified {
return errors.Newf("found mod file %v that has different package path %q than given %q"+
"Uninstall existing tool using `%v@none` or use `-n` flag to choose different name", e, mf.DirectPackage().Path(), target.Path(), targetName)
"Uninstall existing tool using `%v@none` or use `-n` flag to choose different name", e, dpkg.Path(), target.Path(), targetName)
}
return errors.Newf("found array mod file %v that has different package path %q than previous in array %q. Manual edit?"+
"Uninstall existing tool using `%v@none` or use `-n` flag to choose different name", e, mf.DirectPackage().Path(), target.Path(), targetName)
"Uninstall existing tool using `%v@none` or use `-n` flag to choose different name", e, dpkg.Path(), target.Path(), targetName)
}

target.Module.Path = mf.DirectPackage().Module.Path
target.Module.Path = dpkg.Module.Path
if target.Module.Version == "" {
// If no version is requested, use the existing version.
target.Module.Version = mf.DirectPackage().Module.Version
target.Module.Version = dpkg.Module.Version
}
target.RelPath = mf.DirectPackage().RelPath
target.RelPath = dpkg.RelPath

// Save for future versions without potentially existing files.
pkgPath = target.Path()
Expand Down Expand Up @@ -629,7 +639,14 @@ func getPackage(ctx context.Context, logger *log.Logger, c installPackageConfig,
if err != nil {
return errors.Wrap(err, "create tmp mod file")
}
defer errcapture.Do(&err, tmpModFile.Close, "close")

var closed bool
defer func() {
// This defer func is only to handle below set directive method failures since they still need to keep the file open.
if !closed {
errcapture.Do(&err, tmpModFile.Close, "close")
}
}()

if !tmpModFile.IsDirectivesAutoFetchDisabled() && !fetchedDirectives.isEmpty() {
if err := tmpModFile.SetReplaceDirectives(fetchedDirectives.replace...); err != nil {
Expand All @@ -656,11 +673,19 @@ func getPackage(ctx context.Context, logger *log.Logger, c installPackageConfig,
return errors.Wrap(err, "install")
}

tmpModFileFilepath := tmpModFile.Filepath()

// We have close it once here so the defer func does not need to close it again.
closed = true
if err := tmpModFile.Close(); err != nil {
return err
}

// We were working on tmp file, do atomic rename.
if err := os.Rename(tmpModFile.Filepath(), outModFile); err != nil {
if err := os.Rename(tmpModFileFilepath, outModFile); err != nil {
return errors.Wrap(err, "rename mod file")
}
if err := os.Rename(bingo.SumFilePath(tmpModFile.Filepath()), outSumFile); err != nil {
if err := os.Rename(bingo.SumFilePath(tmpModFileFilepath), outSumFile); err != nil {
return errors.Wrap(err, "rename sum file")
}
return nil
Expand Down
Loading