Repository navigation
fix(import): stop short-section pdfs collapsing and step numbers swallowing chapters - #132
Merged
vishwajeet-13 merged 2 commits intoOct 10, 2026
Conversation
…lowing chapters - cleanup: a "Page N" label at the page edge is stripped like a bare page number - cleanup: a running "Chapter > Section" breadcrumb becomes the chapter heading, with the page's heading nested under it - sectionize: a "Topic (continued)" or "Continued from the previous page" heading folds into the open section - sectionize: a numbered heading that continues a run of bare step numbers on its page is a list step, not a chapter - page plan: when no top-level section qualifies as a page, the ones that open a pdf page still are
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
Your trial has ended. Reactivate Greptile to resume code reviews.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
There was a problem hiding this comment.
Your trial has ended. Reactivate Greptile to resume code reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two regressions from #124, found by re-importing PDFs on
main.repeat_prescribing_protocol.pdf(36 pages) ended up as a single "Preamble" page, with "Page N" lines and "Chapter > Section" breadcrumbs left in the text.erpnext-upgrade-playbook.pdf, the step badges came through as headings ("1", "2", "3 Run bench migrate"), so step 3 swallowed every chapter after it. A numbered heading that continues a run of bare step numbers on its page is now a list step.I re-ran the section tree and page plan on all 61 stored imports. Only these two PDFs change.
Screenshots
Short-topic PDF
Numbered step