Skip to content

fix: task board hides a busy project's open tasks past the 500-row limit #197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Venkateshvenki404224 wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

fix: task board hides a busy project's open tasks past the 500-row limit #197

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion frontend/src/components/dashboard/ProjectsTab.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ import type { HiveProject, HiveTask } from '@/types'

/** Enough projects and tasks for an overview; the Projects page paginates. */
const PROJECT_LIMIT = 100
const TASK_LIMIT = 500
const TASK_LIMIT = 2000

interface TaskCounts {
total: number
Expand Down Expand Up @@ -75,6 +75,7 @@ const tasks = useList<HiveTask>({
doctype: 'Hive Task',
fields: ['name', 'project', 'status', 'is_internal'],
filters: { is_archived: 0 },
orderBy: 'modified desc',
limit: TASK_LIMIT,
cacheKey: 'dashboard-project-tasks',
})
Expand Down
4 changes: 2 additions & 2 deletions frontend/src/pages/ProjectDetailPage.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -273,8 +273,8 @@ const tasks = useList<HiveTask>({
'modified',
],
filters: () => ({ project: projectName.value, is_archived: 0 }),
orderBy: 'due_date asc',
limit: 500,
orderBy: 'due_date asc, modified desc',
limit: 2000,
immediate: false,
})

Expand Down
10 changes: 7 additions & 3 deletions frontend/src/pages/TasksPage.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,6 +230,10 @@ const hideProject = computed(() => Boolean(projectFilter.value) || groupBy.value

// -- data ----------------------------------------------------------------

const taskFilters = computed(() =>
projectFilter.value ? { is_archived: 0, project: projectFilter.value } : { is_archived: 0 },
)

const tasks = useList<HiveTask>({
doctype: 'Hive Task',
fields: [
Expand All @@ -251,9 +255,9 @@ const tasks = useList<HiveTask>({
'creation',
'modified',
],
filters: { is_archived: 0 },
orderBy: 'due_date asc',
limit: 500,
filters: taskFilters,
orderBy: 'due_date asc, modified desc',
limit: 2000,
cacheKey: 'tasks-page',
})

Expand Down