Skip to content

fix: description editor toolbar gives no hint that it scrolls #196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
NagariaHussain merged 1 commit into from
Sep 27, 2026
Merged

fix: description editor toolbar gives no hint that it scrolls #196

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion frontend/src/components/common/RichEditor.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,10 +19,12 @@
class="flex items-center justify-between gap-2 border-t border-outline-gray-2 px-2 py-1.5"
>
<EditorFixedMenu
ref="toolbarMenu"
:editor="editor"
:items="toolbar"
button-size="xs"
class="min-w-0 overflow-x-auto [scrollbar-width:none] [&::-webkit-scrollbar]:hidden"
:style="{ maskImage: toolbarMask, WebkitMaskImage: toolbarMask }"
/>
<slot name="actions" :editor="editor" :is-empty="isEmpty" />
</div>
Expand All @@ -32,7 +34,7 @@
</template>

<script setup lang="ts">
import { computed } from 'vue'
import { computed, ref, type ComponentPublicInstance } from 'vue'
import { upload } from 'frappe-ui'
import {
CommentKit,
Expand All @@ -46,6 +48,7 @@ import {
type RichTextKitOptions,
type UploadedFile as EditorUploadedFile,
} from 'frappe-ui/editor'
import { useScrollFade } from '@/composables/useScrollFade'

/** Matches frappe-ui's `MentionSuggestionItem`: free-form beyond id + label. */
export interface MentionItem {
Expand Down Expand Up @@ -88,6 +91,9 @@ defineSlots<{

const toolbar = computed(() => (props.kit === 'rich' ? articleToolbar : commentToolbar))

const toolbarMenu = ref<ComponentPublicInstance | null>(null)
const { mask: toolbarMask } = useScrollFade(computed(() => toolbarMenu.value?.$el))

const extensions = computed(() => {
// A getter, so the suggestion list follows `mentions` without rebuilding the
// extension. Omitted entirely when the caller passes none.
Expand Down
Loading