Repository navigation
fix: recurring tasks spawn overdue and duplicate occurrences - #193
Merged
NagariaHussain merged 2 commits intoSep 26, 2026
Merged
Conversation
There was a problem hiding this comment.
Your trial has ended. Reactivate Greptile to resume code reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Completing an overdue recurring task created the next occurrence with a due date already in the past. A daily task last due on 23 Sep, closed on 26 Sep, came back due 24 Sep, so it had to be closed once for every missed day. Reopening a completed task and closing it again also created a second copy of the next occurrence.
Fix
_maybe_spawn_recurrencekeeps adding the recurrence period until the next due date is on or after today, so the cadence is kept. It also skips creating an occurrence while the series already has an open, unarchived task. Tasks without recurrence are unaffected.One example
Occurrence was set to daily and even after moving it to done, task appears again in To-Do. Had to change occurrence to never.