Repository navigation
feat(plugins): let plugins import frappe-ui's Dialog - #242
Merged
Merged
Conversation
The kit failed any plugin build that imported Dialog, to stop a dialog on top of Commera's action dialog. That blocked normal uses on pages and cards, such as a create form or a confirmation. Plugins can now import Dialog anywhere. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The dashboard stylesheet scanned only a plugin's .vue files, so a class or icon used only in shared .js code, such as a Dropdown option icon, had no style and drew nothing. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Oct 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Plugins can now import frappe-ui's
Dialogon pages, cards, settings and actions. The dashboard stylesheet now also styles classes that a plugin uses only in its.jsor.tsfiles.#241 has these same three commits. It merged into
feat/order-hooksafter #201 had merged that branch intodevelop, so the commits did not reachdevelop.Why
The build kit refused every
Dialogimport to prevent a dialog on top of Commera's action dialog. That is a UX preference, not a technical limit, and it blocked normal page uses such as a create form or a confirmation. A plugin author can decide this. We can add a rule later if plugins misuse it.The stylesheet scanned only
commera/**/*.vuein each plugin. A class or icon that appears only in shared.jscode, for example aDropdownoption icon, got no style and drew nothing.What changed
@commera/plugin-kitno longer fails a build that importsDialogfromfrappe-ui. The kit README no longer lists it.dashboard/tailwind.config.jsscanscommera/**/*.{vue,js,ts}in each installed plugin.bench build --app commeraso that existing plugins pick up classes from their.jsfiles.Dialogunder build checks. Remove it there.Screenshots
A plugin page that opens a
Dialog:A
Dropdownoption icon set only in a plugin's.jsfile. Before, the Duplicate icon is blank. After, it draws:🤖 Generated with Claude Code