Repository navigation
fix(dashboard): add ticket types from the view, not a toolbar button - #661
Merged
Merged
Conversation
Drop the toolbar Add button. Each view now carries its own add action: list view and the phone chip view end with an Add ticket type button, grouped and board keep their per-category plus. The empty state offers Add ticket type. New Category moves to the outline variant.
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Your trial has ended. Reactivate Greptile to resume code reviews.
Contributor
Backend test coverage: 93%Commit d1fe3ac. Test modules are excluded. Coverage by file
104 empty files skipped. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
The toolbar on Ticket Types had both New Category and Add, which was confusing. The Add button is gone. You now add a ticket type from the view you are on:
New Category now uses the outline variant.
Demo
List
Grouped
Board
Phone
Testing