Repository navigation
fix(themes): make font, title and accent tokens take effect - #659
Merged
Merged
Conversation
Event titles were hard-coded to League Gothic, so font-display barely changed the page. Solid buttons ignored the accent tokens since the move to espresso buttons, and measure/aside were required but unused. - add required font-title (League Gothic is now a font choice) and title-size tokens; drop measure and aside - map accent, accent-hover and accent-ink onto solid es-buttons - a new theme saved without tokens starts from the standard theme - Duplicate no longer copies is_standard - patch existing custom themes with the title tokens
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Your trial has ended. Reactivate Greptile to resume code reviews.
Contributor
Backend test coverage: 93%Commit 8d559ce. Test modules are excluded. Coverage by file
104 empty files skipped. |
Contributor
There was a problem hiding this comment.
Your trial has ended. Reactivate Greptile to resume code reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
font-displaybarely showed. Addfont-titleandtitle-sizetokens.accenttokens.measureandasidetokens.is_standard.