Repository navigation
feat(check-in): check-in zones - #651
Merged
Merged
Conversation
Every event gets a 'Main Entrance' zone that cannot be deleted or disabled. Check-ins record their zone, defaulting to the event's default zone, and a patch backfills zones for existing events and check-ins.
The check-in endpoints take a zone. Each zone applies its own repeat rule and optional ticket type list, and validate reports the ticket's state at every enabled zone. The guest list and the attendance report read one zone, the default zone when none is given.
A Check-in zones section lists the event's zones with their repeat rule, ticket types and an enabled switch. A dialog adds, edits and deletes zones.
The scanner remembers a zone per device and event, or Any zone, and sends it with every scan, check-in, undo and guest list fetch. The guest dialog shows the attendee's state at each zone, with per-zone check-in and undo in Any zone mode. Manage > Guests filters check-in status by zone.
set_only_once on the zone's event compared the autoincrement event name as an int against its stored string, so every save of a zone failed. The zone now refuses a move to another event in validate instead.
Contributor
Backend test coverage: 93%Commit 6e8aa38. Test modules are excluded. Coverage by file
106 empty files skipped. |
The guest list response now carries, for each enabled zone, how many guests checked in out of the tickets it lets in, plus each guest's status at every zone. Picking a zone narrows the list to the tickets it admits. ZoneStatus moves to the events schemas to break an import cycle.
Zones open in the same side drawer as collaborators and ticket types. The repeat rule becomes a segmented control and ticket types become toggle chips, with help text that follows the choice.
- Compact stat cards (frappe-ui NumberCard and ChartCard) for registrations, check-ins and the ticket type mix. - A Check-in zones section with a card per zone showing progress. Picking a card narrows the list and the stats to that zone; the edit and add actions open the zone drawer. - Each guest row gets a dot per zone: green when checked in, hollow when the ticket is not allowed there. - Quick actions lead with a Check-in tile, then copy link, manage zones and CSV export.
The default zone links to its event, so deleting an event failed the link check. Zones now go with the event unless it has check-ins, which still block the delete on their own link.
The legend was a list, so it counted as guest rows for assistive tech and the e2e row count.
Hovering the zone dots on a guest row lists every zone with its check-in time, or whether the guest has not checked in or is not allowed there, under a count of the zones checked in.
The zone hover card rows are ItemListRow, so they match frappe-ui menus, and the zone card bar is Progress instead of a hand-drawn bar.
The search takes three quarters of the row and the zone select the rest, with a floor so a zone name stays readable on a phone. Scan stays in the header.
- A zone always narrows the guest list to the tickets it lets in, so the front desk no longer lists guests it would refuse. - Disabled zones cannot narrow the list. - A zone only accepts ticket types of its own event. - Check-in locks the ticket row, so two desks cannot record it twice. - One query reads an existing check-in and its time. - A check-in without a zone says so; zones are no longer renameable.
- The check-in dialog reads zone statuses from the guest row instead of validating the ticket again, and a check-in or undo refreshes the row. - In Any zone mode the dialog stays open after a check-in. - A check-in from an earlier day shows its date, not only the time. - Zone cards hide edit and add for members who cannot edit the event. - One zoneRulesLabel serves the zone cards and the settings panel.
# Conflicts: # buzz/api/events/__init__.py # buzz/api/events/services.py # buzz/patches.txt # dashboard/src/pages/manage/events/EventGuests.vue
The sidebar now carries a notifications count, so the first bare number on the page is no longer the registration total.
On a phone the search and zone picker stack, and Scan becomes a solid button floating at the bottom centre, where the thumb rests. Wider screens keep the side-by-side row and the header button.
harshtandiya
marked this pull request as ready for review
October 25, 2026 20:20
Contributor
There was a problem hiding this comment.
Your trial has ended. Reactivate Greptile to resume code reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Check-in zones: named checkpoints of an event (a hall, a workshop, lunch, swag pickup) that front desk checks attendees into independently.
Event Check-in Zonedoctype. Every event gets a default "Main Entrance" zone that can be renamed but not disabled or deleted; a patch adds it to existing events and files existing check-ins under it.zone(default zone when empty). Validate with no zone ("Any zone") returns the ticket's status at every zone.Demo
Testing
test_event_check_in_zone.py, zone cases inapi/checkin/test_checkin.pyandapi/events/test_event_guests.py, refund block at a non-default zone.bench migrateon a local site (1045 events, 178 check-ins backfilled).check-in.spec.tsand Guest list specs pass.