Repository navigation
feat(event-page): countdown pill on the event banner - #554
Merged
Merged
Conversation
Shows the time left until the start on the event's public page, worded like the dashboard pill (63d 5h 12m). Under an hour it adds seconds. Changed characters roll into place, and a short blur crossfade carries the switch to Live. The server leaves the pill out once the event ends. base.css now carries the build version in its URL. It had a 12 hour cache, so a returning visitor could get the new script with the old stylesheet and see the pill unstyled. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Your trial has ended. Reactivate Greptile to resume code reviews.
Contributor
Backend test coverage: 91%Commit 66ab5d7. Test modules are excluded. Coverage by file
89 empty files skipped. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Countdown pill on the public event banner, matching the dashboard's
EventCountdownPill.Starting in 63d 5h 12mStarting in 5h 12mStarting in 12m 38sLiveAlso
base.cssgets?v={{ build_version }}so stale cached CSS can't leave the pill unstyled.EventMeta.time_zone→event_time_zone(event)inmeta.py, shared with structured data.Tests
buzz/www/event/test_event_render.py— upcoming, ended, no end time.buzz/public/js/time_left.test.ts— format per unit range.test_event.py::test_schedule_talk_shows_title_and_speakersfails ondeveloptoo; unrelated.