test: build every backend test fixture with factories

.claude/skills/writing-tests/SKILL.md

@@ -17,8 +17,10 @@ Faker comes with frappe. Do not add it to `pyproject.toml`.
 1. **Never** build a fixture with `frappe.get_doc({...}).insert()` or `frappe.new_doc(...)`.
    Use a factory. If the doctype has none, write it first.
 2. One factory per doctype: `buzz/tests/factories/<snake_case_doctype>_factory.py`, class
-   `<PascalCaseDocType>Factory(BaseFactory[<DocClass>])`, re-exported from `__init__.py`.
-   The generic is the real controller class, so the result is typed.
+   `<PascalCaseDocType>Factory(BaseFactory[<DocClass>])`, re-exported from
+   `buzz/tests/factories/__init__.py`; import it from `buzz.tests.factories`. The generic is
+   the real controller class, so the result is typed. `buzz/tests/test_factories.py` creates
+   every factory in `__all__`, so a new factory is smoke-tested once it is exported.
 3. `default_attributes` sets only what `.insert()` needs. Leave out fields with a DocType
    default or a controller fallback (`Event Booking.status`, the INR 0 price row
    `Event Ticket Type.before_validate` adds).
@@ -109,12 +111,24 @@ the session user.
 
 ## Traps
 
-**Administrator must not own throwaway teams.** `create_default_team_for` picks the first
-enabled Owner membership, and `process_booking` commits, so its fixtures survive rollback.
-An Administrator-owned test team becomes Administrator's default team on that site, and
-`setup_test_records()` fails with `Venue Test Venue belongs to another team.` Use
+**Administrator must not own throwaway teams.** `setup_test_records()` gives Administrator
+exactly one team, and Event Template and event proposal submissions fill `team` from a sole
+membership. `process_booking` commits, so its fixtures survive rollback. A second
+Administrator team leaks across runs and breaks that lookup. Use
 `BuzzTeamFactory.create_owned_by()`.
 
+**`Buzz Event` names are autoincrement integers.** `.name` is an `int` in memory, and the
+whitelisted APIs type-check `event: str`. Pass `str(event.name)`, and compare against `str(...)`
+when the other side came from the database.
+
+**`get_fullname` caches per process.** A user rebuilt in a later class keeps the earlier
+name in that cache. Set the name the test asserts, and read it from the field the code reads.
+
+**`frappe.set_user` is allowed only in `test_*.py`.** The `frappe-setuser` semgrep rule
+fails CI anywhere else, for example in `buzz/tests/base_test_cases.py` or a factory. Use
+`with self.set_user(user):`, `self.enterContext(self.set_user(user))` in `setUp`, or
+`frappe.tests.classes.context_managers.set_user` outside a test case.
+
 **User creation is throttled** at 60 new users an hour (`User.throttle_user_creation`), and
 test users leak. For a fixed identity use `UserFactory.create_once(email)`; use `create()`
 only for a distinct user.
@@ -150,10 +164,17 @@ class BookingTestCase(IntegrationTestCase):
 
 `buzz/api/booking/test_booking.py` is the reference conversion.
 
-Older modules still export ad-hoc helpers — `create_user` / `create_owned_team` /
-`payload_for` in `test_buzz_team.py`, `ensure_prompt_named_record` in `test_forms.py`,
-`create_event` / `create_ticket` in `test_permissions.py`. They retire module by module. Do
-not add new callers.
+Never import from another `test_*.py`. Shared base classes (`BookingTestCase`,
+`CouponTestCase`, `BookingRefundTestCase`, `SponsorshipTestCase`, `TeamPermissionTestCase`)
+live in `buzz/tests/base_test_cases.py`. Shared non-fixture helpers (email queue readers,
+telemetry capture, `clear_map_link_cache`) live in `buzz/tests/utils.py`.
+
+Use the Frappe context managers rather than manual cleanup: `self.set_user`,
+`self.change_settings` (Singles only), `self.freeze_time`, `self.patch_hooks`.
+`Buzz Team Settings` is not a Single, so use `BuzzTeamFactory.set_settings(team, values)`.
+
+CI formats with ruff 0.8.1. Run `uvx ruff@0.8.1 format buzz && uvx ruff@0.8.1 check buzz`
+before pushing; a newer ruff wraps lines differently.
 
 ## Running tests
 

buzz/api/account/test_account.py

@@ -6,7 +6,6 @@
 from frappe.utils import set_request
 
 from buzz.api.account import (
-	get_enabled_languages,
 	get_translations,
 	get_user_info,
 	update_user_language,
@@ -17,14 +16,7 @@
 
 
 class LanguageTestCase(IntegrationTestCase):
-	"""Base for the tests that exercise language resolution.
-
-	`get_language` reads cookies and headers off the live request, which a test
-	process does not have until one is installed.
-	"""
-
-	def tearDown(self):
-		frappe.set_user("Administrator")
+	"""`get_language` reads cookies and headers off the live request, which a test process lacks."""
 
 	def install_request(self, cookies: dict[str, str] | None = None, accept_language: str = ""):
 		headers = {}
@@ -37,11 +29,7 @@ def install_request(self, cookies: dict[str, str] | None = None, accept_language
 		self.addCleanup(setattr, frappe.local, "request", None)
 
 	def other_enabled_language(self) -> str:
-		"""An enabled language that is not the site default.
-
-		Plain codes only: a regional one like `pt-BR` comes back as a different
-		string once werkzeug has parsed the Accept-Language header.
-		"""
+		"""Plain codes only: werkzeug rewrites a regional one like `pt-BR` when it parses the header."""
 		for language in get_all_languages():
 			if language != get_default_language() and language.isalpha():
 				return language
@@ -57,24 +45,24 @@ def set_user_language(self, language: str | None):
 class TestGetUserInfo(LanguageTestCase):
 	def test_guest_payload_keys(self):
 		self.install_request()
-		frappe.set_user("Guest")
-		info = get_user_info().__json__()
+		with self.set_user("Guest"):
+			info = get_user_info().__json__()
 
 		self.assertEqual(set(info), {"is_logged_in", "brand_image", "language"})
 		self.assertFalse(info["is_logged_in"])
 
 	def test_guest_language_follows_the_preferred_language_cookie(self):
 		language = self.other_enabled_language()
 		self.install_request(cookies={"preferred_language": language})
-		frappe.set_user("Guest")
 
-		self.assertEqual(get_user_info().__json__()["language"], language)
+		with self.set_user("Guest"):
+			self.assertEqual(get_user_info().__json__()["language"], language)
 
 	def test_guest_language_falls_back_to_the_site_default(self):
 		self.install_request()
-		frappe.set_user("Guest")
 
-		self.assertEqual(get_user_info().__json__()["language"], get_default_language())
+		with self.set_user("Guest"):
+			self.assertEqual(get_user_info().__json__()["language"], get_default_language())
 
 	def test_logged_in_payload_shape(self):
 		info = get_user_info().__json__()
@@ -99,20 +87,8 @@ def test_logged_in_payload_shape(self):
 		self.assertTrue(info["is_logged_in"])
 		self.assertEqual(info["name"], "Administrator")
 
-	def test_roles_stay_child_table_rows(self):
-		roles = get_user_info().__json__()["roles"]
-
-		self.assertTrue(roles)
-		self.assertTrue(any(row.role == "Administrator" for row in roles))
-
 
 class TestLanguages(LanguageTestCase):
-	def test_enabled_languages_shape(self):
-		languages = [language.__json__() for language in get_enabled_languages()]
-
-		self.assertTrue(languages)
-		self.assertEqual(set(languages[0]), {"name", "language_name", "language_code"})
-
 	def test_update_rejects_unknown_language(self):
 		frappe.clear_messages()
 
@@ -123,9 +99,6 @@ def test_update_rejects_unknown_language(self):
 		self.assertEqual(message["title"], "Language Not Available")
 		self.assertIn("not-a-language", message["message"])
 
-	def test_unknown_language_maps_to_400(self):
-		self.assertEqual(UnknownLanguage.http_status_code, 400)
-
 	def test_update_persists_language(self):
 		self.set_user_language(None)
 
@@ -139,14 +112,6 @@ def test_update_stays_closed_to_guests(self):
 
 
 class TestTimezones(IntegrationTestCase):
-	def tearDown(self):
-		frappe.set_user("Administrator")
-
-	def set_user_timezone(self, time_zone: str | None):
-		original = frappe.db.get_value("User", "Administrator", "time_zone")
-		self.addCleanup(frappe.db.set_value, "User", "Administrator", "time_zone", original)
-		frappe.db.set_value("User", "Administrator", "time_zone", time_zone)
-
 	def test_update_rejects_unknown_timezone(self):
 		frappe.clear_messages()
 
@@ -157,9 +122,6 @@ def test_update_rejects_unknown_timezone(self):
 		self.assertEqual(message["title"], "Timezone Not Available")
 		self.assertIn("Mars/Olympus_Mons", message["message"])
 
-	def test_unknown_timezone_maps_to_400(self):
-		self.assertEqual(UnknownTimezone.http_status_code, 400)
-
 	def test_update_persists_timezone(self):
 		self.set_user_timezone(None)
 
@@ -168,7 +130,6 @@ def test_update_persists_timezone(self):
 		self.assertEqual(frappe.db.get_value("User", "Administrator", "time_zone"), "Asia/Kolkata")
 
 	def test_update_accepts_utc(self):
-		"""The dashboard's picker puts UTC at the top of the list."""
 		self.set_user_timezone(None)
 
 		update_user_timezone("UTC")
@@ -179,35 +140,32 @@ def test_update_stays_closed_to_guests(self):
 		self.assertIn(update_user_timezone, frappe.whitelisted)
 		self.assertNotIn(update_user_timezone, frappe.guest_methods)
 
+	def set_user_timezone(self, time_zone: str | None):
+		original = frappe.db.get_value("User", "Administrator", "time_zone")
+		self.addCleanup(frappe.db.set_value, "User", "Administrator", "time_zone", original)
+		frappe.db.set_value("User", "Administrator", "time_zone", time_zone)
 
-class TestGetTranslations(LanguageTestCase):
-	def resolved_language(self) -> str:
-		"""The language get_translations picked, without loading any."""
-		with patch("buzz.api.account.get_all_translations", return_value={}) as translations:
-			get_translations()
-
-		translations.assert_called_once()
-		return translations.call_args.args[0]
 
+class TestGetTranslations(LanguageTestCase):
 	def test_guest_translations_follow_the_preferred_language_cookie(self):
 		language = self.other_enabled_language()
 		self.install_request(cookies={"preferred_language": language})
-		frappe.set_user("Guest")
 
-		self.assertEqual(self.resolved_language(), language)
+		with self.set_user("Guest"):
+			self.assertEqual(self.resolved_language(), language)
 
 	def test_guest_translations_fall_back_to_the_accept_language_header(self):
 		language = self.other_enabled_language()
 		self.install_request(accept_language=language)
-		frappe.set_user("Guest")
 
-		self.assertEqual(self.resolved_language(), language)
+		with self.set_user("Guest"):
+			self.assertEqual(self.resolved_language(), language)
 
 	def test_guest_translations_fall_back_to_the_site_default(self):
 		self.install_request()
-		frappe.set_user("Guest")
 
-		self.assertEqual(self.resolved_language(), get_default_language())
+		with self.set_user("Guest"):
+			self.assertEqual(self.resolved_language(), get_default_language())
 
 	def test_logged_in_translations_follow_the_user_document(self):
 		language = self.other_enabled_language()
@@ -219,3 +177,11 @@ def test_a_user_without_a_language_gets_the_site_default(self):
 		self.set_user_language(None)
 
 		self.assertEqual(self.resolved_language(), get_default_language())
+
+	def resolved_language(self) -> str:
+		"""The language get_translations picked, without loading any."""
+		with patch("buzz.api.account.get_all_translations", return_value={}) as translations:
+			get_translations()
+
+		translations.assert_called_once()
+		return translations.call_args.args[0]

buzz/api/auth/test_auth.py

@@ -1,43 +1,17 @@
-import frappe
 from frappe.tests import IntegrationTestCase
 
 from buzz.api.auth import get_login_context
 
 
 class TestGetLoginContext(IntegrationTestCase):
-	def tearDown(self):
-		frappe.set_user("Administrator")
-
-	def test_returns_expected_keys(self):
-		context = get_login_context().__json__()
-		self.assertEqual(
-			set(context),
-			{
-				"disable_signup",
-				"disable_user_pass_login",
-				"login_with_email_link",
-				"login_banner",
-				"provider_logins",
-			},
-		)
-
-	def test_settings_flags_stay_integers(self):
-		context = get_login_context().__json__()
-		for key in ("disable_signup", "disable_user_pass_login", "login_with_email_link"):
-			self.assertIsInstance(context[key], int)
-
 	def test_banner_is_rendered_as_html(self):
-		frappe.db.set_single_value("Buzz Settings", "login_banner", "# Welcome")
-		self.addCleanup(frappe.db.set_single_value, "Buzz Settings", "login_banner", None)
-
-		self.assertIn("<h1", get_login_context().__json__()["login_banner"])
+		with self.change_settings("Buzz Settings", login_banner="# Welcome"):
+			self.assertIn("<h1", get_login_context().__json__()["login_banner"])
 
 	def test_banner_is_none_when_unset(self):
-		frappe.db.set_single_value("Buzz Settings", "login_banner", None)
-
-		self.assertIsNone(get_login_context().__json__()["login_banner"])
+		with self.change_settings("Buzz Settings", login_banner=None):
+			self.assertIsNone(get_login_context().__json__()["login_banner"])
 
 	def test_available_to_guest(self):
-		frappe.set_user("Guest")
-
-		self.assertIsInstance(get_login_context().__json__()["provider_logins"], list)
+		with self.set_user("Guest"):
+			self.assertIsInstance(get_login_context().__json__()["provider_logins"], list)

buzz/api/booking/test_booking.py

@@ -1,7 +1,6 @@
 from unittest.mock import patch
 
 import frappe
-from frappe.tests import IntegrationTestCase
 
 from buzz.api.booking import (
 	get_booking_details,
@@ -12,19 +11,16 @@
 	validate_coupon,
 )
 from buzz.api.booking.exceptions import AddOnNotForEvent, InvalidAddOnValue, RegistrationsClosed
-from buzz.api.booking.schemas import BookingRequest
+from buzz.tests.base_test_cases import BOOKER, OUTSIDER, BookingTestCase
 from buzz.tests.factories import (
 	BuzzCouponCodeFactory,
 	BuzzCustomFieldFactory,
 	BuzzEventFactory,
 	EventTicketTypeFactory,
 	OfflinePaymentMethodFactory,
 	TicketAddOnFactory,
-	UserFactory,
 )
 
-BOOKER = "booking-owner@example.com"
-OUTSIDER = "booking-outsider@example.com"
 VALID_PHONE = "+91-9000090000"
 
 EVENT_DATA_FIELDS = {
@@ -97,44 +93,6 @@
 }
 
 
-class BookingTestCase(IntegrationTestCase):
-	@classmethod
-	def setUpClass(cls):
-		super().setUpClass()
-		cls.booker = UserFactory.create_once(BOOKER).name
-		cls.outsider = UserFactory.create_once(OUTSIDER).name
-		cls.event = BuzzEventFactory.create()
-		cls.event.reload()
-
-	def setUp(self):
-		frappe.set_user("Administrator")
-		frappe.clear_messages()
-		self.addCleanup(frappe.clear_document_cache, "Buzz Event", self.event.name)
-		self.set_event({"is_published": 1, "registrations_close_at": None, "allow_guest_booking": 0})
-		self.free_ticket_type = EventTicketTypeFactory.create(event=self.event.name)
-
-	def set_event(self, values):
-		frappe.db.set_value("Buzz Event", self.event.name, values)
-		frappe.clear_document_cache("Buzz Event", self.event.name)
-
-	def enable_phone_otp(self):
-		self.set_event({"allow_guest_booking": 1, "guest_verification_method": "Phone OTP"})
-
-	def booking_request(self, **overrides):
-		values = {
-			"attendees": [
-				{
-					"first_name": "Booker",
-					"email": "booker@example.com",
-					"ticket_type": str(self.free_ticket_type.name),
-				}
-			],
-			"event": str(self.event.name),
-		}
-		values.update(overrides)
-		return BookingRequest(**values)
-
-
 class TestSendGuestBookingOtp(BookingTestCase):
 	def test_disabled_guest_booking_is_refused(self):
 		with self.assertRaises(frappe.ValidationError):