fix: Fix rule's null value comparisons for is and isNot#198
Merged
Conversation
2 tasks
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #198 +/- ##
==========================================
- Coverage 97.64% 97.62% -0.03%
==========================================
Files 21 21
Lines 3231 3237 +6
==========================================
+ Hits 3155 3160 +5
- Misses 76 77 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The JS implementation can be seem on the file condition.ts. On Actual rules, most
Noneevaluations will use the guard:When using
isandisNotcomparing withNonevalues, there is an exception since it usesfieldValue === this.valueandfieldValue !== this.value. We should allow the comparison to evaluate with the nullable field instead.Another bug fix was comparing a null to a string object. There is a specific guard for this behavior:
Here, the correct option is to convert both sides to an empty string, then use the compare function instead.
Closes #197