fix: Fix create schedule not inserting the next scheduled date.#195
Merged
Conversation
2 tasks
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #195 +/- ##
==========================================
+ Coverage 97.60% 97.64% +0.03%
==========================================
Files 21 21
Lines 3212 3222 +10
==========================================
+ Hits 3135 3146 +11
+ Misses 77 76 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
create_schedulecreates the schedule and its rule/conditions correctly, but never inserts a row into theschedules_next_datetable. The Actual frontend requires this row to compute and display the next occurrence date. Without it, the Next Date column is blank and the frontend crashes when attempting to edit the date field.Here is the reference implementation from Actual: https://github.com/actualbudget/actual/blob/c0c2d1630ede6d58347af9e6a194dfa701f1fa37/packages/loot-core/src/server/schedules/app.ts#L288-L295
Closes #193