fix: Correctly retrieve transactions when running rules.#188
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #188 +/- ##
=======================================
Coverage 98.01% 98.01%
=======================================
Files 21 21
Lines 3131 3131
=======================================
Hits 3069 3069
Misses 62 62 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
Note that running this also includes closed accounts - which may not be intuitive. Which it was doing before this PR - but the is_parent heavily reduced the number of transactions affected. |
Owner
Author
As discussed in #186 (reply in thread), seems like this is the default for the UI, so I'll keep it for now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Aligns behaviour with the Actual UI when running rules against split transactions using the
run_rulesmethod.Reported by @JaxOfDiamonds.
Reworks some of the points discussed in #186, where the rules didn't run correctly when using
run_rules.