Skip to content

fix: Correctly retrieve transactions when running rules.#188

Merged
bvanelli merged 2 commits into
mainfrom
fix/run-runs-for-split-transactions
Mar 10, 2026
Merged

fix: Correctly retrieve transactions when running rules.#188
bvanelli merged 2 commits into
mainfrom
fix/run-runs-for-split-transactions

Conversation

@bvanelli
Copy link
Copy Markdown
Owner

@bvanelli bvanelli commented Mar 9, 2026

Aligns behaviour with the Actual UI when running rules against split transactions using the run_rules method.

Reported by @JaxOfDiamonds.

Reworks some of the points discussed in #186, where the rules didn't run correctly when using run_rules.

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 9, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.01%. Comparing base (df250ee) to head (e844d58).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #188   +/-   ##
=======================================
  Coverage   98.01%   98.01%           
=======================================
  Files          21       21           
  Lines        3131     3131           
=======================================
  Hits         3069     3069           
  Misses         62       62           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@JaxOfDiamonds
Copy link
Copy Markdown
Contributor

Note that running this also includes closed accounts - which may not be intuitive. Which it was doing before this PR - but the is_parent heavily reduced the number of transactions affected.

@bvanelli
Copy link
Copy Markdown
Owner Author

Note that running this also includes closed accounts - which may not be intuitive. Which it was doing before this PR - but the is_parent heavily reduced the number of transactions affected.

As discussed in #186 (reply in thread), seems like this is the default for the UI, so I'll keep it for now.

@bvanelli bvanelli merged commit 6410640 into main Mar 10, 2026
9 checks passed
@bvanelli bvanelli deleted the fix/run-runs-for-split-transactions branch March 10, 2026 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants