[pull] main from apache:main#186
Merged
Merged
Conversation
## Which issue does this PR close? No issue opened, but discovered regression in unit tests in datafusion-python during upgrading to `main` ## Rationale for this change Documentation only to let users know that they will need to update their field naming expectations. The change happened in #20886 ## What changes are included in this PR? Upgrade guide document. ## Are these changes tested? N/A --------- Co-authored-by: hsiang-c <137842490+hsiang-c@users.noreply.github.com> Co-authored-by: Oleks V <comphead@users.noreply.github.com>
…2071) ## Which issue does this PR close? - Closes to #14896 - Related to #21120 ## Rationale for this change I think the fact that we have 2 sets of statics functions is confusing. I think we should mark the copy that is not used as deprecated. A bit over a year ago, thanks to @Fly-Style and @ozankabak, DataFusion we merged a PR with a "V2" statistics framework - #14699 The work to migrate the code to use this new framework is tracked in a follow on ticket - #14896 Sadly, no progress seems to have been made in this migration in over a year. PR #14699 was merged on 2025-02-24, ~15 months ago. Since then, the only commits touching `datafusion/expr-common/src/statistics.rs` and `datafusion/physical-expr/src/statistics/` have been mechanical — no operator or planner has been taught to call `evaluate_statistics` / `propagate_statistics` or construct a `Distribution` outside of the framework's own tests. In practice it has never been wired into the optimizer or any execution operator. Recently, thanks to @asolimando we have been starting down a different path of a more extensible system: - #21120 That issue explicitly describes the V2 distribution-based API as "significantly more complex to implement and adopt" and proposes that distribution-based estimation, if useful, be plugged in later as a custom analyzer rather than as a `PhysicalExpr` trait surface. Rather than continue carrying an unused public framework that we don't intend to build on, let's deprecate it so downstream users aren't confused ## What changes are included in this PR? This PR adds `#[deprecated(since = "54.0.0", ...)]` attributes to the public abstractions introduced in #1469 There is no behavior changes; the V2 code paths still compile and run, so any out-of-tree consumer that has already adopted them sees a deprecation warning rather than a breakage. ## Are these changes tested? No new tests; the existing tests for the deprecated items continue to pass. ## Are there any user-facing changes? The public API items listed above are now marked `#[deprecated]`. Downstream code that uses them will see a compiler warning pointing to #21120, but will continue to compile and run unchanged. The deprecated items will be removed in a future release. Partly generated 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )