feat: preserve presentation slide identity - #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Inline::Anchor("slide-N")for every PPTX, legacy PPT, and ODP slide in source order, including empty slides.Block::Ruleonly between content-bearing slides. Empty slides retain their anchor and do not add a doubled separator..nodeartifacts, runsnpm pack --ignore-scripts, verifies native files in the tarball, and uploads the tarball to the GitHub release.Distribution decision
Chosen option (b), vendor a packed tarball. The available npm credential is the personal
vishhvakaccount and has no Sapiex organization scope, so publishing a production dependency under that account is not acceptable. Nonpm publishcommand was run, and the release workflow contains no npm publish command. The Node package now includesanydoc.*.nodein itsfileslist so one packed archive is self-contained on every target. The release workflow also packs the existing Wasm package as a release asset instead of publishing it.The local Darwin smoke archive was:
Its literal contents included:
The seven-target CI matrix remains the source for the release asset used by Sapiex.
Verification
Actual command output:
Node pack and binding smoke output:
Upstream split
The model and tests are isolated in commit
d7f5a2dand pushed asupstream-slide-identity. The fork-only CI and release changes are in40528db.