Branch/trend anomaly fixes and refactorings#4
Merged
Conversation
…ocket schema doc(Agents): Updates agents internationalision instructions, add bulk-action checklist to AGENTS.md chore(storybook): Updates storybook package json scripts to sb short form chore(tests): Adds test:watch and per test project splits fix(trends): Fixes backend anomaly trends validation
…atom Replace raw <select> elements and _renderSelect() helpers across all six analysis molecules (trend, threshold, sample, rate, anomaly, sidebar) with the <inline-select> atom. Extend SelectOption with disabled? so individual options can be greyed out. Also disables "Same as display trend" in the anomaly trend method picker when show_trend_lines is off, falling back to the first real method so the select is never left on a disabled option. Update all unit and Storybook interaction tests to query inline-select and dispatch dp-select-change instead of the native change event.
At <=900px the .page-sidebar rule sets min-width: min(380px, 85vw) for the overlay state. The .page-sidebar.collapsed override set width: auto but never cleared min-width, so the collapsed 52px pill sidebar retained a ~380px minimum width, overflowed its grid column, and disappeared behind the chart stacking context. Adding min-width: 0 to the collapsed rule at that breakpoint lets the sidebar correctly constrain to its 52px grid column. doc: Removed statistics card reference from README and github templates
Extract the full README into four topic documents: - docs/cards.md — all six cards, visual editors, panel description, YAML configs - docs/recording-datapoints.md — record action, fields, automation patterns, examples - docs/history-and-analysis.md — chart features, all trend methods, anomaly detection - docs/development.md — setup, build, i18n deep dive, remote HA dev, WebSocket API, CI README becomes a concise overview with badges, screenshots, why/what summary, a docs table linking to each topic, translations note, roadmap, installation, setup, and a quick-start snippet.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Anomaly trend override — the trend deviation anomaly method can now use an independent trend algorithm (e.g. LOWESS for anomaly detection while the chart shows linear). A new "Same as display trend" option is the default; it is automatically disabled and falls back to the first available method when trend lines are turned off for the series. Backend Python and WebSocket schema updated to support all five trend methods.
inline-selectmigration — removed the duplicated_renderSelect()helper from all five analysis/anomaly molecules and the chart-display sidebar section. All selects now use the shared<inline-select>atom.SelectOptionextended withdisabled?: boolean;inline-selectrenders disabled<option>elements accordingly.Tablet layout fix — at 720–900 px the collapsed sidebar was overflowing behind the chart because
.page-sidebarsetsmin-width: min(380px, 85vw)at that breakpoint and.page-sidebar.collapsednever reset it. Addedmin-width: 0to the collapsed rule.Docs split — the README was split into four focused documents (
docs/cards.md,docs/recording-datapoints.md,docs/history-and-analysis.md,docs/development.md) with the README reduced to an overview that links to each.Hook fix —
scripts/prepare-commit-msgnow skips messages prefixed withfixup!orsquash!sogit rebase --autosquashsubject matching is not corrupted.