fix(llm): update code for symphonia 0.6 and bech32 0.11 breaking API changes#4479
Merged
Merged
Conversation
…changes symphonia 0.6: - Probe::format() renamed to Probe::probe(), now returns Box<dyn FormatReader> directly - Hint moved from core::probe to core::formats::probe - get_codecs().make() renamed to make_audio_decoder() taking AudioCodecParameters - codec_params is now Option<CodecParameters> enum requiring pattern match - default_track() now requires TrackType argument - SampleBuffer removed; use copy_to_slice_interleaved on GenericAudioBufferRef - next_packet() now returns Result<Option<Packet>> - track_id is a public field, not a method bech32 0.11: - ToBase32 trait removed; encode takes raw bytes internally - Variant::Bech32 removed; use encode::<Bech32>(hrp, bytes) with Hrp::parse
github-actions
Bot
added
llm
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes compilation breakage introduced by the dependency bumps in #4478.
symphonia 0.5.5 → 0.6.0 (
crates/zeph-llm/src/candle_whisper.rs):Probe::format()renamed toProbe::probe(), now returnsBox<dyn FormatReader>directly instead ofProbeResultHintmoved fromcore::probetocore::formats::probeCodecRegistry::make()renamed tomake_audio_decoder(), takes&AudioCodecParameterstrack.codec_paramsis nowOption<CodecParameters>enum — requiresCodecParameters::Audio(p)matchFormatReader::default_track()now requires aTrackTypeargumentSampleBufferremoved — usecopy_to_slice_interleavedonGenericAudioBufferRefFormatReader::next_packet()now returnsResult<Option<Packet>>packet.track_id()is now a public fieldpacket.track_idbech32 0.9.1 → 0.11.1 (
crates/zeph-llm/src/gonka/signer.rs):ToBase32trait removed —encodenow handles base32 conversion internallybech32::Variant::Bech32removed — useencode::<Bech32>(hrp, bytes)withHrp::parseTest plan
cargo build --features full— cleancargo build --features full --release— cleancargo +nightly fmt --check— cleancargo clippy --features full -- -D warnings— cleancargo nextest run --workspace --lib --bins— 10037 passed, 21 skipped