Only include dependencies in java maven-deps stages#2325
Closed
Only include dependencies in java maven-deps stages#2325
Conversation
All the lifecycle plugins are part of our maven-jdk base image, so we exclude those by using dependency:copy-dependencies instead of go-offline. This copies only declared dependencies and their transitive deps, cutting repository size by 43% (133M -> 76M). Changes: - Switch from dependency:go-offline to dependency:copy-dependencies - Remove <packaging>pom</packaging> (not needed with copy-dependencies) - Remove <build><plugins> section (dead weight - compile service reads kotlin config from database, not from pom.xml) - Add kotlin-maven-plugin as a <dependency> for copy-dependencies to fetch - Add -Dmdep.copyPom=true to ensure POM files are copied alongside JARs (needed for Maven to resolve plugins from local file:// repository)
Maven needs parent POMs (protobuf-parent, protobuf-bom, etc.) to resolve dependency descriptors from a local file:// repository. After copy-dependencies populates /maven-repository with JARs and their POMs, copy all .pom files from .m2/repository to pick up parent POM ancestry.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All the lifecycle plugins are part of our maven-jdk base image, so we want to exclude those. Regenerates the existing plugins.