Open
Conversation
Follow up to #5. This upgrades: * `buf` to latest * `golangci-lint` to match buf's version, up to v2 * Fixes some minor lints * go.mod version to 1.25.0 (n-1) * Add 2026 to copyright years
Member
Author
|
Seems that CI isn't running on branches yet; fixed that in this PR, but won't run until this lands on $ make test; and make lint
license-header \
--license-type apache \
--copyright-holder "Buf Technologies, Inc." \
--year-range "2025-2026" --ignore testdata/
go build ./...
go test -vet=off -race -cover ./...
ok buf.build/go/app 1.328s coverage: 38.3% of statements
ok buf.build/go/app/appcmd 1.762s coverage: 51.0% of statements
buf.build/go/app/appcmd/appcmdtesting coverage: 0.0% of statements
ok buf.build/go/app/appext 1.538s coverage: 25.7% of statements
go vet ./...
GOTOOLCHAIN=go1.26.1 golangci-lint run --modules-download-mode=readonly --timeout=3m0s
0 issues. |
stefanvanburen
commented
Mar 19, 2026
Comment on lines
-333
to
+335
| *runErrAddr = errors.New("Sub-command required.") | ||
| *runErrAddr = errors.New("sub-command required") | ||
| } else { | ||
| *runErrAddr = fmt.Errorf("Unknown sub-command: %s", strings.Join(args, " ")) | ||
| *runErrAddr = fmt.Errorf("unknown sub-command: %s", strings.Join(args, " ")) |
Member
Author
There was a problem hiding this comment.
not sure if we feel strongly about keeping these?
And use latest/previous names, similar to connect-go.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to #5. This upgrades:
bufto latestgolangci-lintto match buf's version, up to v2