chore(ci): add stage 1 rspec infrastructure#5
Open
blackjid wants to merge 3 commits into
Open
Conversation
Wire up minimal Gemfile, lockfile, GitHub Actions CI, and bin/ci so specs can run locally and in CI against a single dependency stack. Co-authored-by: Cursor <cursoragent@cursor.com>
Wire up budacom/github-actions reusable_claude_review so PRs can get feedback via @claude mentions and /review comments. Co-authored-by: Cursor <cursoragent@cursor.com>
ActiveResource object equality is unreliable across query paths. Assert on record ids and attributes instead so CI passes on Ruby 3.4. Co-authored-by: Cursor <cursoragent@cursor.com>
blackjid
force-pushed
the
chore/stage1-rspec-ci
branch
from
5533a6c to
5f3c5b6
Compare
Author
|
@claude /review |
aundurraga
reviewed
Jul 1, 2026
| PATH | ||
| remote: . | ||
| specs: | ||
| buda_active_resource (1.0.0) |
Contributor
There was a problem hiding this comment.
aqui no habria que cambiarlo a buda_active_resource?
y en las partes donde esta ActiveAdminResource::Base a BudaActiveResource::Base? porque si no estamos testeando la gema original?
Author
There was a problem hiding this comment.
mm, este lock esta generado solo al correr bundle instal ( o bundle lock) contra el Gemile.
me pierdo un poco.., BudaActiveResource hay que usarla explicitamente?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Gemfiledependencies (rails,active_admin_resource) so specs can bootGemfile.lockand pin Ruby 3.4 via.ruby-versionbundle exec rspecon push/PRbin/cihelper and README instructions for running specs locallyThis is stage 1 only: infrastructure to run specs in a single environment. Spec fixes and multi-version matrix come in a follow-up PR.
Test plan
bundle install && bundle exec rspecboots the suite on Ruby 3.4bin/ciruns the same commandMade with Cursor