Conversation
Let's see how this affects memory usage and performance. Related to buchgr#473.
|
@BoyangTian-Robinhood if you get a chance to try this out, please let me know how it goes. |
|
I did some tests, run some bazel test for same packages by cherry-pick this changes on top of SummaryWith this commit. Compare zstd with uncompressed:zstd highest memory is 3 times higher than without zstd, and when it stable zstd memory is 1.74 times higher. For disk saving it is around 3.29 times saving with zstd. Without this commit. Compare zstd with uncompressed:zstd highest memory is 3.8 times higher than without zstd, and when it stable zstd memory is 2.3 times higher. For disk saving it is around 3.29 times saving with zstd. Compare with this commit and without this commit zstd saving:memory saving on peak is 1.04 times. memory saving on stable is 1.12 times. And disk has no change. But it seems zstd also has memory leak issue even with grpc goroutines fix DetailStart new service without anything there, memory is around 6MB. Head is this commit (647f07b)With zstd optionsmemory peak is 1.54GB, stable is 268MB, disk is: 677MB Still this commit by using
|
Let's see how this affects memory usage and performance.
Related to #473.