Feat/enable sasl types - #3
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Adds support for configuring kroxy to authenticate upstream Kafka connections for PLAIN clients using SCRAM-SHA-256/512, enabling a PLAIN→SCRAM bridging mode while keeping existing SCRAM pass-through behavior intact.
Changes:
- Introduces
upstream.DialSCRAMand SCRAM client-side authentication flow using franz-go’s SCRAM mechanism. - Adds proxy-side decision logic to translate PLAIN client auth into upstream SCRAM auth when
upstream.sasl.mechanismis configured. - Documents the new configuration and behavior, and adds targeted unit/integration-style tests.
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| upstream/scram_test.go | New in-process fake SCRAM broker test validating DialSCRAM end-to-end. |
| upstream/conn.go | Adds DialSCRAM and SCRAM client handshake driver (scramAuthenticate). |
| README.md | Documents upstream.sasl.mechanism and explains PLAIN→SCRAM translation semantics. |
| proxy/translate_internal_test.go | Adds unit test for PLAIN→SCRAM translation decision logic. |
| proxy/listener.go | Extends ServerConfig with UpstreamSASLMechanism. |
| proxy/conn.go | Dials upstream via DialSCRAM when translation is enabled; improves upstream logging. |
| dockerfiles/kroxy.yaml | Example/commented config snippet for upstream SCRAM translation. |
| config/config.go | Adds upstream.sasl.mechanism config struct and validates SCRAM-only values. |
| config/config_test.go | Adds config coverage for valid/invalid upstream.sasl.mechanism values. |
| cmd/kroxy/main.go | Wires config value into proxy.ServerConfig. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.