add tls termination - #2
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds optional client-side TLS termination to kroxy’s Kafka listener, configured via YAML and wired through to the proxy server so clients can connect over TLS while the upstream broker connection remains plaintext.
Changes:
- Introduces
tlsconfiguration (enabled/cert_file/key_file) with validation and aBuild()helper that loads the server keypair. - Wraps the client-facing listener with TLS when configured, and logs whether TLS is enabled.
- Adds test coverage for TLS handshake + SASL/PLAIN over TLS, plus documentation updates and an example config snippet.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| README.md | Documents the new tls config block and updates scope notes to reflect client TLS termination support. |
| proxy/listener.go | Adds TLS wrapping for the client listener and logs TLS enablement. |
| proxy/listener_tls_test.go | Adds integration-style tests for TLS handshake + SASL/PLAIN and plaintext rejection behavior. |
| dockerfiles/kroxy.yaml | Adds commented example tls configuration for the demo stack. |
| config/config.go | Adds TLSConfig, validation, and Build() to produce *tls.Config (or nil when disabled). |
| config/config_test.go | Adds unit tests for TLSConfig.Build() and config validation scenarios. |
| cmd/kroxy/main.go | Wires cfg.TLS.Build() into proxy.NewServer via ServerConfig.TLS. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add tls support