Skip to content

Revert "fix(codex): forward output token limit" #283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PsiACE merged 1 commit into from
Aug 15, 2026
+0 −18
Merged

Revert "fix(codex): forward output token limit" #283

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions src/bub/builtin/codex_provider.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,9 +136,6 @@ def _completion_params_to_responses_params(self, params: CompletionParams) -> Re
response_format=params.response_format,
stream=params.stream,
parallel_tool_calls=params.parallel_tool_calls,
max_output_tokens=(
params.max_completion_tokens if params.max_completion_tokens is not None else params.max_tokens
),
reasoning=reasoning,
)

Expand Down
15 changes: 0 additions & 15 deletions tests/test_builtin_codex.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,25 +189,10 @@ def test_codex_completion_params_use_official_responses_payload_fields() -> None
assert payload == {
"model": "gpt-5.5",
"input": [{"role": "user", "content": "hello"}],
"max_output_tokens": 100,
"stream": True,
}


def test_codex_completion_params_prefer_max_completion_tokens() -> None:
provider = OpenaiCodexProvider(api_key=_jwt_with_account("acct_123"))
params = CompletionParams(
model_id="gpt-5.5",
messages=[{"role": "user", "content": "hello"}],
max_tokens=100,
max_completion_tokens=200,
)

responses_params = provider._completion_params_to_responses_params(params)

assert responses_params.max_output_tokens == 200


def test_codex_completion_params_convert_chat_tool_messages_to_responses_items() -> None:
provider = OpenaiCodexProvider(api_key=_jwt_with_account("acct_123"))
params = CompletionParams(
Expand Down
Loading