Repository navigation
v2.2.1 — Interface Cleanup - #6
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9260d9194c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| const backdrop = $('#modalBackdrop'); | ||
| if (backdrop.hidden) return; | ||
| backdrop.hidden = true; | ||
| if (modalReturnFocus?.isConnected) modalReturnFocus.focus(); |
There was a problem hiding this comment.
When the About dialog is opened from the profile menu, the click handler hides that menu before showAbout() awaits app information and calls openModal(). As a result, modalReturnFocus is either the now-hidden menu item or the document body; checking only isConnected here can therefore return focus to an invisible element—or nowhere useful—when the dialog closes. Preserve the profile button as the trigger or verify that the saved element remains visible and fall back to #profileMenuButton.
Useful? React with 👍 / 👎.
| $required = @( | ||
| 'LICENSE', | ||
| 'RELEASE_NOTES_v2.2.1.md', | ||
| 'STABLE_TAG_SIGNING.md', |
There was a problem hiding this comment.
This workflow treats STABLE_TAG_SIGNING.md as required release material, but that guide still directs operators exclusively to .github/workflows/publish-v2.2.0-stable.yml, the PUBLISH-v2.2.0 confirmation, and a package version of exactly 2.2.0. An operator following the required guide for the pending v2.2.1 publication will therefore select the old workflow, which rejects the newly bumped package; document the new workflow, confirmation, sequence, and asset names before publication.
Useful? React with 👍 / 👎.
Page headings competed with actions, navigation overflowed short windows, and long dialogs could exceed the viewport. This patch centers headings above wrapping actions, lets the sidebar and dialogs scroll, lets panel headers grow, and adds keyboard focus, icon labels, disabled-button feedback, and reduced-motion support. Dialogs now contain keyboard focus and return focus to their trigger when closed. About release labels are consistent.
Validation: JavaScript syntax, update verification, update transaction/rollback, signed publisher policy tests for v2.2.0 and v2.2.1, dialog focus tests, and git diff whitespace checks passed. The dialog test covers hidden/disabled controls, both Tab directions, modal replacement, Ctrl+K containment, Escape, focus restoration, and a removed trigger. Browser visual verification could not run because Chromium downloads failed. Native Windows smoke tests and packaging have not been performed; this PR remains draft pending those checks.
Version: 2.2.1. No configuration migration. Installer and Portable artifact names advance to 2.2.1. A manual signed publisher is prepared with the existing hash, signature, verified-tag, commit-binding, and published-asset checks preserved. No release has been published. README explicitly retains v2.2.0 as the published Stable version; the v2.2.1 changelog and release notes are marked unreleased.
Before merge/publication: inspect all centers at 1180×760 and 1540×980, Windows 125%/150% scaling, long dialogs, keyboard focus, and installer/portable upgrade and rollback behavior.