Repository navigation
Fix Account & Session Center reliability for v2.5.1 - #20
Conversation
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 51eca9b2d1
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "version": "2.5.1", | ||
| "resolved": "https://registry.npmjs.org/@electron/notarize/-/notarize-2.5.1.tgz", | ||
| "integrity": "sha512-jNT8nwH1f9X5GEITXaQ8IF/KdskvIkOFfB2CvwumsveVidzpSc+mvhhTMdAGSYF3O+Nq49lJ7y+ssODRXu06+A==", |
There was a problem hiding this comment.
On a clean dependency install, this changes the fetched @electron/notarize artifact to 2.5.1 while retaining the integrity hash recorded for 2.5.0. npm's package-lock documentation defines integrity as the hash “for the artifact that was unpacked in this location,” so a different version's tarball cannot satisfy this entry. The Windows release workflow's Install dependencies step runs npm ci before layout verification and packaging, making this inconsistent lock entry a release blocker. Restore the notarize version, resolved URL, and app-builder-lib dependency requirement to their original values rather than including this transitive package in the application version bump.
Useful? React with 👍 / 👎.
Fixes Account & Session Center cancellation, policy retry, join tracking, background draft preservation and process-scan consistency for v2.5.1. Application styling and existing functionality are retained.
New behavioral regressions reproduce closure during authentication/handoff, Stop all during ticket acquisition, failed/initial policy retries, ended-session snapshot cleanup and a replacement session being falsely ended against an older process scan. Four original backend failures were reproduced before fixes. All 223 automated tests now pass. Actual Electron renderer checks preserve blurred scheduler/appearance/settings input identity and values across the background poll.
Windows source/release/layout verification gates run in CI. Synthetic verification does not terminate Roblox or change real accounts/Windows policies. Stable packaging includes Setup, Portable, Fast Folder, source and checksums. Existing optional-feature limits, CPU/FPS permission requirements and unsigned/exact-file VirusTotal notices remain documented.