Review navigation: grouped sections, a reading order, and approvals pinned to content - #21

Open

jbachorik wants to merge 113 commits into

mainfrom

Commits on Aug 26, 2026

Review navigation gets a design: entry points, order and links

jbachorik
and
claude
committed
f2116cf
Review navigation design: grouping is the binding constraint, not order

jbachorik
and
claude
committed
df1e53c
Tests are reviewed beside the code they pin, not on their own card

jbachorik
and
claude
committed
69b2cfe
A hunk belongs to every section that explains it, and is reviewed once

jbachorik
and
claude
committed
f444721
Scope names the reviewed-state change, not the id scheme it replaced

jbachorik
and
claude
committed
b1fc1ef
An approval is valid only for the content and base it was given against

jbachorik
and
claude
committed
acce500
Staleness fires only when the base move could matter, and says what it cannot fix

jbachorik
and
claude
committed
3879457
An agent may add staleness to an approval, never take it away

jbachorik
and
claude
committed
567487f
Review navigation gets an implementation plan

jbachorik
and
claude
committed
f9bdc9a
An approval is pinned to a hunk's content, not its position
jbachorik
committed
fe54635
Fix: use import for Locale instead of fully-qualified class name
jbachorik
committed
80d8ef3
A verdict is keyed by hunk content and names the base it was given against
jbachorik
committed
04cf57b
Verdicts are stored per hunk digest, and the legacy migration is deleted
jbachorik
committed
799445d
review_state reports a verdict under the intent's own id, not its storage key
jbachorik
committed
47c64c5
review_state degrades gracefully when a scope's diff cannot be produced
jbachorik
committed
8ea5a12
A section's decision is derived from its hunks, not stored
jbachorik
committed
5a38b01
A base move marks approvals stale only when it could matter

jbachorik
and
claude
committed
36d4fae
Parsing of git diff output handles non-ASCII filenames correctly

jbachorik
and
claude
committed
6bd4de9
Progress counts hunks, and a section's state is derived from them
jbachorik
committed
9e9f0ca
Unknown staleness is silent, and a drifted section cannot deadlock Submit
jbachorik
committed
1e0fdfa
A section's derivation lives in SectionStates, outside the view
jbachorik
committed
6b80e9c
Settle a hunk, a file or a section, and say which one a key will hit
jbachorik
committed
70b8e14
Settle the real hunk in view, not a stuck focus flag or the anchor
jbachorik
committed
4649864
Name the acting unit on the Approve button, not a label the floor hides
jbachorik
committed
8d4d305
Read the unit pressed, not what focus becomes, and free the listener on close
jbachorik
committed
de7e947
A stale hunk stops counting one layer up too, not just in the bar
jbachorik
committed
f1420f2
Fit-check the bar's own height and the stale label, not just its buttons
jbachorik
committed
58cd8c1
tree-sitter grammars are a packaging decision, not an architectural one
jbachorik
committed
b573f45
A broken grammar class only falls back for its own extensions
jbachorik
committed
888cff5
A file contributes what it declares and what it uses, however it is parsed
jbachorik
committed
7a98e88
Narrow the tree-sitter fallback to the calls that can actually fail
jbachorik
committed
95b3128
The change graph resolves a name only when exactly one file declares it
jbachorik
committed
60881ed
A use mints an edge wherever it sits in the diff window, not only on a
jbachorik
committed
d1a026a
Kahn and Tarjan, hand-rolled, with a total tie-break
jbachorik
committed
9b08c4f
Graphs rejects a dependency on a node outside the given set
jbachorik
committed
687a2b3
Sections follow the code's structure, not its folders

jbachorik
and
claude
committed
21d7cc1
Sections name what a card is about, and no two read the same

jbachorik
and
claude
committed
cd39bb5
A multi-line declaration keeps its name in the change graph

jbachorik
and
claude
committed
6737e8c
A qualified name references the type that qualifies it

jbachorik
and
claude
committed
ef37062
Files that are not code contribute no symbols at all

jbachorik
and
claude
committed
f2dd3d5
A name that appears only in documentation is not a reference

jbachorik
and
claude
committed
66d47a9
The rail renders computed sections when no reviewer has run
jbachorik
committed
e5117e7
A closed view stops a background section graph from touching it
jbachorik
committed
15a02e2
A computed section's id is derived from its hunks, not its position
jbachorik
committed
90c083a
Computed cards carry over the fallback's kind and risk
jbachorik
committed
94cacdb
A cycle rationale names at most three files, and stops pointing outward
jbachorik
committed
8bf6515
A blocking finding survives its intent's id changing under it
jbachorik
committed
269a9b3
Computed intents are worked out once per refresh, not once per finding
jbachorik
committed
e686977
A diff already graphed is not re-parsed on every scope redisplay
jbachorik
committed
c717717
The rail can say its grouping is provisional
jbachorik
committed
df6093a
The reviewer's cursor follows the intent across a grouping swap
jbachorik
committed
5291b3b
Pin the computed-id, degenerate-fallback and rail-swap behaviour with tests
jbachorik
committed
d0b25b4
A javadoc reference uses an import, not an inline qualified name
jbachorik
committed
f5e863c
The verdict bar and the write path agree on what blocks approval
jbachorik
committed
4515ba2
The provisional-grouping notice gets its own row
jbachorik
committed
0803a3a
Pin content-derived ids against an actual reorder, not just reproducibility
jbachorik
committed
3436326
A computed id hashes the section's files too, not just its hunks
jbachorik
committed
5294aa1
A failed graph build is retried, logged, and stops claiming to refine
jbachorik
committed
44daed4
The intents cache survives across refreshes, not just within one
jbachorik
committed
99d2b5e
A computed section's id now genuinely depends on its hunk digest too
jbachorik
committed
5f0dcec
belongsToIntent's javadoc admits the safety relaxation it made
jbachorik
committed
98cbbe6
review_scope can hand the agent the grouping it is being asked to name
jbachorik
committed
cc7d34c
review_scope charges sections against the budget and degrades gracefully
jbachorik
committed
18dea22
Staleness also notices a base move in a file a section only references
jbachorik
committed
b91d8e1
One bounded git grep recovers the strongest entry-point signal

jbachorik
and
claude
committed
9c3f0a1
A real no-matches spawn pins exit code 1 as an empty answer

jbachorik
and
claude
committed
19a05e1
Where to start, what follows it, and why

jbachorik
and
claude
committed
79fec4f
The entry-point rank drops the term that cannot discriminate

jbachorik
and
claude
committed
20c5648
The change graph answers per hunk as well as per file

jbachorik
and
claude
committed
c9a8eed
Links state something true about one hunk

jbachorik
and
claude
committed
c6143dd
The path carries the section order it implies

jbachorik
and
claude
committed
ba1bfac
The rank's authoritative list names the terms the rank actually has

jbachorik
and
claude
committed
e3813b1
p walks the change in reading order
jbachorik
committed
5d54275
PATH rows get their own text fills instead of a Button's default
jbachorik
committed
0823a81
A part-settled stale hunk no longer reads as untouched
jbachorik
committed
68cb9d9
a, r and u in PATH mode settle the row on screen, not a section
jbachorik
committed
1ea3c60
Computed intent cards number off the reading path too
jbachorik
committed
dd92b6a
PATH mode no longer bypasses the blocking-finding refusal
jbachorik
committed
12e2df8
The verdict bar reflects and acts on the selected PATH row
jbachorik
committed
91f9268
Pin the verdict bar's PATH-mode render, and askAgentToFix's hand-off
jbachorik
committed
d1eff4c
A hunk says what it has to do with the hunks around it

jbachorik
and
claude
committed
70bf8bc
revealHunk matches a hunk's real index, not its position among rendered headers

jbachorik
and
claude
committed
ffd71c2
A link click widens out of a filter that hides its own target

jbachorik
and
claude
committed
24248f1
setLinks keeps an open comment composer instead of silently dropping it

jbachorik
and
claude
committed
8fcd5a5
Request the scope's graph unconditionally, so links show under a reviewer's own grouping too

jbachorik
and
claude
committed
1d953a5
Pin the reviewer-grouping link footer fix that mutation testing found unguarded

jbachorik
and
claude
committed
7dbedb7
Called from 3 places outside the change, and you can see which three

jbachorik
and
claude
committed
2048493
Keep the reader on their hunk when the scan re-sorts the path under them

jbachorik
and
claude
committed
4bf9e7b
The bar's "Ask the agent to fix it" can no longer do nothing quietly

jbachorik
and
claude
committed
3105001
p means start at the beginning, even when the path moved while you were away

jbachorik
and
claude
committed
b47d5d1
A test class owns its own stage size, all thirty-six of them

jbachorik
and
claude
committed
6a220c7
Measure the bar where it actually is, not where the window is

jbachorik
and
claude
committed
e745ba5
An agent may say which intents its intents are built on

jbachorik
and
claude
committed
428da1e
A reads that is not an array of ids is broken, not absent

jbachorik
and
claude
committed
869f51c
An agent may add staleness to an approval, never take it away

jbachorik
and
claude
committed
281cdfc
A mark with no reason, and a broken affected, are both refused

jbachorik
and
claude
committed
16a1739
A base move asks the agent which approvals it actually disturbed

jbachorik
and
claude
committed
fae871e
An ordering says whether drydock measured it or an agent claimed it

jbachorik
and
claude
committed
b663adb
The automatic recheck waits until git has said the move could matter

jbachorik
and
claude
committed
f133007
Relevance is decided per approval, not per section

jbachorik
and
claude
committed
faac736
The recheck scan drops a guard that only added work

jbachorik
and
claude
committed
19c82c3
The diag script can finally deliver a key to the Review view

jbachorik
and
claude
committed
0e21078
A claimed ordering is legible, and an agent's staleness says so too

jbachorik
and
claude
committed
1e5cf4a
An automatic recheck leaves a trace, dispatched or not

jbachorik
and
claude
committed
3d03854
A diag verb that does not exist says so, instead of impersonating mark

jbachorik
and
claude
committed
8748e45
A documented diag verb without a case fails the build, not a screenshot run

jbachorik
and
claude
committed
9527abe
Log Scene focus state on the CI-only settle-unit failure
jbachorik
committed
9236b14
Close the async graph-build race that flaked ReviewSettleActionsTest on CI
jbachorik
committed
a33ebac
Wait for the actual postcondition after focusDiffColumn's click, not a fixed drain count
jbachorik
committed
a5643b4
TEMPORARY: log whether the diff-column click even reaches production code on CI
jbachorik
committed
930bf58
Remove the temporary click diagnostics now that CI is green
jbachorik
committed
a26e219
Try moveTo+press+release for the diff-column click; restore diagnostics
jbachorik
committed
d9277bd
Identify exactly which focus owner steals the diff-column click
jbachorik
committed
e834975