Open
Conversation
also rename `.kitchen.yml` to `kitchen.yml` the new test fails because on chef 17 (ruby 3) it never runs any tests
remove the rspec monkey patching (caused by chef requiring inspec) and then reintroduce the minitest monkey patching
- since we no longer depend on `chef_handler` cookbook we need chef 14 - also put gems in the metadata.rb and remove old attributes and resources since this will be a major version change
Contributor
Author
|
@btm, the change to require Chef 14+ as well as switching the gem to be defined in If you don't want that I can split this into two PRs, one with the Chef 14+ breaking change stuff, and one with the hack to get RSpec/Inspec to stop messing with minitest. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Work in progress to get some of this stuff working on Chef 17.
Use newer Minitest gemProbably not this. The newer minitest is pretty incompatible with minitest-chef-handler gem and I don't want to fix that.Also fixes the gem update stuff that's in these dependabot PRs: