fix: honor "save + start now" in the editor wizard; hub ctrl+e feedback - #26
Merged
Merged
Conversation
The embedded add wizard offered "save + start now" but the editor silently downgraded it to a plain draft: nothing started, even after saving. The choice now jumps straight into the save pipeline (diff -> write) with the draft marked to start, and a successful save starts the session detached via a fresh manager over the post-save config. The status line reports saved + started, a start failure, or a skipped start when tmux is unavailable. Hub: ctrl+e on a session that is not in the config was a silent no-op, which reads as a dead key when the highlighted session is tmux-only. It now reports "<name> is not in the config", matching S.
The list screenshot rendered at 700px next to the 850px hub and editor shots. All three are 850 now. Reworked the intro to cover what mox is today (config-defined sessions, ad-hoc sessions, the hub) and cleaned the punctuation throughout.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two UX fixes from this morning's session, plus a README pass.
Save + start now actually starts
Creating a session through the editor's embedded add wizard (
mox editthena) and choosing "save + start now" silently downgraded to a plain draft: nothing was written untils, and the session never started at all.The choice now jumps straight into the save pipeline (diff preview, Enter to write), and a successful save starts the session detached, same semantics as the hub's
S. The status line reports the outcome:saved + started <name> (detached), a start failure with the error, orstart skipped: tmux unavailable. The start hook builds a fresh manager over the post-save config, since saves replacest.cfg.Hub ctrl+e feedback
ctrl+ein the hub only works on configured sessions, but on a tmux-only session it did nothing, with no feedback. Since the hub sorts running sessions first, an unmanaged session is often what's highlighted, and the key read as dead. It now reports<name> is not in the config, matching whatSalready did.README
Testing
TestEditorWizardSaveStart,TestEditorWizardSaveStartFailure,TestEditorWizardSaveStartNoTmux, plus an assertion on the ctrl+e status inTestHubAttachAndEdit. All were written failing first.make testandgolangci-lint run(v2) are clean. No new tmux syntax; the start path reusesManager.Create, which the hub'sSalready exercises.