Repository navigation
release 1.8.3: no-arithmetic warning, changelog split, version bump - #4
Merged
Merged
Conversation
Date the 1.8.2 changelog entry (released 2026-11-08) and move the emitter, REPL and prover fixes that landed after that tag into a new 1.8.3 entry. Bump the package version to 1.8.3. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
The native prover and Vampire (on TPTP) read gt/gte/lt/lte as uninterpreted predicates, so their SAT can miss a conflict that needs arithmetic, such as an integer gap (gt 5 with lt 6 on an Integer). When the ontology uses those comparisons and one of them gives an all-clear: - --solve prints a warning on stderr; - the REPL appends it to :solve, :model, :explain, :unsat and a refuted :prove; - the language server appends it to the ontologic.solve details. auto warns only when it falls back to the native prover. Z3 and CVC5 answers, and every UNSAT, are unchanged. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Release housekeeping
package.yamland the generatedontologic.cabal.New: warning when a prover without arithmetic gives an all-clear
The native prover and Vampire (on TPTP) read
gt,gte,ltandlteas uninterpreted predicates. They catch bounds that directly exclude each other, but their SAT can miss a conflict that needs arithmetic, such as an integer gap (gt 5withlt 6on anInteger). That SAT used to be silent.When the ontology uses those comparisons and one of these provers gives an all-clear:
--solveprints a warning on stderr.:solve,:model,:explain,:unsatand a refuted:prove.ontologic.solvedetails.autowarns only when it falls back to the native prover. Z3 and CVC5 answers, and every UNSAT, are unchanged. A declared relation namedlt(orgt,gte,lte) is not treated as a comparison.After this merges,
v1.8.3is tagged onmain.Test plan
stack test --ghc-options="-Wall -Werror": 770 examples, 0 failures (12 new: 11 intest/RegressionBugsSpec.hs, 1 CLI test intest/MainSpec.hs)test/fixtures/integer_gap.logicwith--solve:-p nativeand-p vampireanswer SAT with the warning;-p z3,-p cvc5and-p autoanswer UNSAT with no warning:solveand:unsatundernative, and is absent underz3ontologic.cabalregenerated by hpack; the only change is the version line🤖 Generated with Claude Code