[Fix] Prevent custom logos from executing scripts - #6
Draft
openroomote-bruno[bot] wants to merge 1 commit into
Draft
openroomote-bruno[bot] wants to merge 1 commit into
openroomote-bruno[bot] wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Why this change was made
Configured SVG logo content could execute as same-origin script when rendered inline. The Docker build also executed a mutable Bun release rather than the repository's reviewed version.
Impact
Custom SVG branding remains supported but is loaded as an inert image, preventing its markup from executing in the application. Image-loaded SVGs retain their own colors rather than inheriting the interface text color. Docker builds now use Bun 1.3.7 consistently.
Browser proof could not be captured because this environment has no configured runnable product browser surface. Focused tests, formatting, and linting passed; Docker build validation could not run because the Docker daemon is unavailable.