Skip to content

[Fix] Cypress metadata test fails intermittently after saved question updates - #5

Draft
openroomote-bruno[bot] wants to merge 1 commit into
masterfrom
fix/deterministic-metadata-wait-3enqfcgn0djit
Draft

openroomote-bruno[bot] wants to merge 1 commit into
masterfrom
fix/deterministic-metadata-wait-3enqfcgn0djit

Conversation

@openroomote-bruno

Copy link
Copy Markdown

​Created by Roomote. View the task or mention @roomote for follow-up asks.

Important

For those employed by Metabase: if you are merging into master, please add either a backport or a no-backport label to this PR. You will not be able to merge until you do this step. Refer to the section Do I need to backport this PR? in the Metabase Branching Strategy document for more details. If you're not employed by Metabase, this section does not apply to you, and the label will be taken care of by your reviewer.

Warning

If that is your first contribution to Metabase, please sign the Contributor License Agreement. Also, if you're attempting to fix a translation issue, please submit your changes to our Crowdin project instead of opening a PR.

Description

The metabase#43216 Cypress scenario no longer assumes dependent-card metadata will propagate within 450 ms. It captures the target question ID and polls its query-metadata endpoint until the expected D field is present, with a shared 10-second deadline and short request timeouts.

This removes an explicitly marked flaky timing assumption and synchronizes the test on the backend state that its later UI assertions require. This is test-only maintenance with no product behavior change.

How to verify

  1. Run e2e/test/scenarios/question-reproductions/reproductions-2.cy.spec.js in a provisioned Metabase Cypress environment.
  2. Confirm the source question update propagates to the target question before the target UI assertions run.

The sandbox has no node_modules/.bin/cypress or application stack, so the Cypress scenario could not be executed here. node --check e2e/test/scenarios/question-reproductions/reproductions-2.cy.spec.js and git diff --check passed.

Demo

Not applicable: this changes E2E synchronization only.

Checklist

  • Tests have been updated to cover changes in this PR
  • If adding new Loki tests: they pass stress testing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant