[Fix] Cypress metadata test fails intermittently after saved question updates - #5
Draft
openroomote-bruno[bot] wants to merge 1 commit into
Draft
openroomote-bruno[bot] wants to merge 1 commit into
openroomote-bruno[bot] wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important
For those employed by Metabase: if you are merging into master, please add either a
backportor ano-backportlabel to this PR. You will not be able to merge until you do this step. Refer to the section Do I need to backport this PR? in the Metabase Branching Strategy document for more details. If you're not employed by Metabase, this section does not apply to you, and the label will be taken care of by your reviewer.Description
The
metabase#43216Cypress scenario no longer assumes dependent-card metadata will propagate within 450 ms. It captures the target question ID and polls its query-metadata endpoint until the expectedDfield is present, with a shared 10-second deadline and short request timeouts.This removes an explicitly marked flaky timing assumption and synchronizes the test on the backend state that its later UI assertions require. This is test-only maintenance with no product behavior change.
How to verify
e2e/test/scenarios/question-reproductions/reproductions-2.cy.spec.jsin a provisioned Metabase Cypress environment.The sandbox has no
node_modules/.bin/cypressor application stack, so the Cypress scenario could not be executed here.node --check e2e/test/scenarios/question-reproductions/reproductions-2.cy.spec.jsandgit diff --checkpassed.Demo
Not applicable: this changes E2E synchronization only.
Checklist