[Fix] Reduce intermittent Cypress test failures - #4
Draft
openroomote-bruno[bot] wants to merge 1 commit into
Draft
openroomote-bruno[bot] wants to merge 1 commit into
openroomote-bruno[bot] wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Replaced two fixed-delay Cypress waits with deterministic synchronization. The embed-settings persistence test now waits for its intercepted settings update, while the table column-width test retries until exactly one rendered header reaches its expected width.
Why this change was made
Recent flake-fix history and the current E2E suite showed these tests relied on elapsed time rather than the state they need. Fixed sleeps are vulnerable to slow CI workers and can also needlessly delay fast runs.
Impact
This is test-only maintenance. It removes timing assumptions from two E2E assertions and should make CI behavior more stable. Full Cypress execution remains to be run in a provisioned Metabase E2E environment because this sandbox does not include repository dependencies or an application stack.