Bootstrap missing tables for incremental materializations - #2516
Open
albertobruin wants to merge 4 commits into
Open
Bootstrap missing tables for incremental materializations#2516albertobruin wants to merge 4 commits into
albertobruin wants to merge 4 commits into
Conversation
Contributor
Prompt To Fix All With AI### Issue 1
pkg/clickhouse/materialization.go:83-88
**Bootstrap drops ClickHouse partitioning**
When a `delete+insert`, `merge`, or `time_interval` asset with `partition_by` runs before its target exists, the bootstrap DDL creates the table without the configured partition key. Since subsequent runs skip `CREATE TABLE IF NOT EXISTS`, the target remains permanently unpartitioned until it is manually rebuilt.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.Reviews (1): Last reviewed commit: "feat: bootstrap incremental materializat..." | Re-trigger Greptile |
Contributor
|
Reviews (2): Last reviewed commit: "chore: satisfy Oracle lint" | Re-trigger Greptile |
albertobruin
force-pushed
the
albertobruin/incremental-create-table
branch
from
August 5, 2026 20:18
03d6ca5 to
d7403b9
Compare
Contributor
|
Reviews (3): Last reviewed commit: "chore: satisfy Oracle lint" | Re-trigger Greptile |
albertobruin
force-pushed
the
albertobruin/incremental-create-table
branch
from
August 6, 2026 13:16
d7403b9 to
3a283aa
Compare
Contributor
|
Reviews (4): Last reviewed commit: "chore: satisfy Oracle lint" | Re-trigger Greptile |
Contributor
|
Reviews (5): Last reviewed commit: "fix: preserve BigQuery bootstrap options" | Re-trigger Greptile |
Contributor
|
This is going to be nice, thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Incremental
merge,delete+insert, andtime_intervalmaterializations now create an empty target from the asset query schema when the target does not exist.Changes
LIKEstagingrequire_partition_filter, andpartition_expiration_daysHow to test
make formatmake testmake build-no-duckdbRisk & rollback
Checklist
make test)make build-no-duckdb,make format)make integration-test)Security
Related issues
N/A