ci(release): only run CLI release for v* version tags - #2278
Open
terzioglub wants to merge 1 commit into
Open
Conversation
The Release workflow triggered on every tag (`tags: ['*']`), so a prefixed tag for an in-repo nested module (e.g. semantic-engine/v0.1.0) would launch a full bruin CLI GoReleaser run with a bogus version. Restrict the trigger to CLI version tags (v0.11.656, etc.). All existing release tags match `v[0-9]*`; module tags like semantic-engine/v0.1.0 do not, so they can be cut safely without touching the CLI release.
Contributor
|
Reviews (1): Last reviewed commit: "ci(release): only run CLI release for v*..." | Re-trigger Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Restrict the Release workflow trigger from
tags: ['*']totags: ['v[0-9]*'].Why
release.ymlruns GoReleaser withVERSION=${{ github.ref_name }}on any tag push. Now that the repo has a nested module (semantic-engine, added in #2277), its versions are cut as prefixed tags likesemantic-engine/v0.1.0. Under the old'*'filter, pushing such a tag would trigger a full CLI release namedsemantic-engine/v0.1.0— a broken/garbage GoReleaser run.All existing CLI release tags (
v0.11.x) matchv[0-9]*; module tags do not. So this preserves current release behavior exactly while making it safe to tag nested modules.Follow-up
Once merged,
semantic-engine/v0.1.0can be tagged so dac can pin the engine module.