Consolidate the duplicated Spell.dbc attribute flag bits

The remaining flag-bit duplicates -- the same drift risk that caused the
AttributesEx2/Ex3 mix-up -- now live once in Offsets.h:
- SPELL_ATTR_PASSIVE (0x40): was already in Offsets.h yet copied in
  Info.cpp and Level.cpp; drop both locals.
- SPELL_ATTR_EX_CHANNELED (0x4|0x40): identical local in Cast.cpp and
  CastEvents.cpp; add to Offsets.h and repoint.
- SPELL_ATTR_EX2_AUTOREPEAT_FLAG (0x20): the same bit under two names
  (Cast's _AUTOREPEAT, AutoAttack's _FLAG); unify in Offsets.h.

Single-use flag bits (TRADESPELL, RANGED, HEALTH_FUNNEL,
HIDDEN_CLIENTSIDE, ON_NEXT_SWING, NOT_RESET_AUTO_ACTIONS) and per-module
effect/target enum codes stay local -- they are not duplicated and read
clearer at the use site.

Author: brues-code

src/Offsets.h

@@ -5774,6 +5774,11 @@ enum Offsets {
     // SPELL_ATTR_EX3_IGNORE_CASTER_MODIFIERS (verified via disassembly; the
     // server enum agrees). NOT AttributesEx2's bit 29 (that's CANT_CRIT).
     SPELL_ATTR_EX3_IGNORE_CASTER_MODIFIERS = 0x20000000,
+    // AttributesEx channel bits (CHANNELED_1 0x4 | CHANNELED_2 0x40) and the
+    // AttributesEx2 autorepeat flag (bit 5, Auto Shot / Shoot) — each shared
+    // by more than one module, so kept here rather than redefined locally.
+    SPELL_ATTR_EX_CHANNELED = 0x4 | 0x40,
+    SPELL_ATTR_EX2_AUTOREPEAT_FLAG = 0x20,
     OFF_SPELL_RECORD_INTERRUPT_FLAGS = 0x54,          // u32 (column 21)
 
     // Remaining Spell.dbc record fields — the single source of truth for the

src/spell/AutoAttack.cpp

@@ -42,7 +42,6 @@ namespace Spell::AutoAttack {
 namespace {
 
 constexpr int SPELL_AUTO_ATTACK = 6603;
-constexpr uint32_t SPELL_ATTR_EX2_AUTOREPEAT_FLAG = 0x00000020;
 
 bool IsMelee(int spellID) {
     return spellID == SPELL_AUTO_ATTACK;
@@ -58,7 +57,7 @@ bool IsRanged(int spellID) {
         return false;
     const uint32_t attrEx2 = *reinterpret_cast<const uint32_t *>(
         rec + Offsets::OFF_SPELL_RECORD_ATTRIBUTES_EX2);
-    return (attrEx2 & SPELL_ATTR_EX2_AUTOREPEAT_FLAG) != 0;
+    return (attrEx2 & Offsets::SPELL_ATTR_EX2_AUTOREPEAT_FLAG) != 0;
 }
 
 int ReadSpellID(void *L) {

src/spell/Cast.cpp

@@ -99,7 +99,6 @@ constexpr uint32_t SPELL_ATTR_TRADESPELL = 0x20;
 // flat +500ms "aim time" to these (SpellEntry::GetCastTime). Auto-repeat
 // shots (Auto Shot / Shoot, AttributesEx2 bit 0x20) are the one exclusion.
 constexpr uint32_t SPELL_ATTR_RANGED = 0x2;
-constexpr uint32_t SPELL_ATTR_EX2_AUTOREPEAT = 0x20;
 
 struct TrackedSpell {
     int spellID; // 0 = not casting / channeling
@@ -184,7 +183,7 @@ int CastTimeMs(int spellID) {
                 *reinterpret_cast<const uint32_t *>(rec + Offsets::OFF_SPELL_RECORD_ATTRIBUTES);
             const uint32_t attrEx2 =
                 *reinterpret_cast<const uint32_t *>(rec + Offsets::OFF_SPELL_RECORD_ATTRIBUTES_EX2);
-            if ((attr & SPELL_ATTR_RANGED) && !(attrEx2 & SPELL_ATTR_EX2_AUTOREPEAT))
+            if ((attr & SPELL_ATTR_RANGED) && !(attrEx2 & Offsets::SPELL_ATTR_EX2_AUTOREPEAT_FLAG))
                 ms += 500;
         }
     }
@@ -334,11 +333,9 @@ const Game::HookAutoRegister _castStartHook{
 // thing at a time). Regular casts back `UnitCastingInfo`; channels add real
 // times to `UnitChannelInfo` (validated against the live +0x228 field).
 
-constexpr uint32_t SPELL_ATTR_EX_CHANNELED = 0x4 | 0x40; // IS_CHANNELED | SELF
-
 bool IsChannelSpell(const uint8_t *rec) {
     return (*reinterpret_cast<const uint32_t *>(rec + Offsets::OFF_SPELL_RECORD_ATTRIBUTES_EX) &
-            SPELL_ATTR_EX_CHANNELED) != 0;
+            Offsets::SPELL_ATTR_EX_CHANNELED) != 0;
 }
 
 // Channel duration for a non-player caster — base (skipMod=1), since we

src/spell/CastEvents.cpp

@@ -254,14 +254,11 @@ int g_pendingChanSuccSpell = 0;
 int g_pendingChanSuccTMs = 0;
 constexpr int kChanSuccDeferMs = 500;
 
-// Spell.dbc AttributesEx channel bits — same test Spell::Cast uses.
-constexpr uint32_t SPELL_ATTR_EX_CHANNELED = 0x4 | 0x40; // IS_CHANNELED | SELF
-
 bool IsChanneledSpell(int spellID) {
     const uint8_t *rec = Spell::Lookup::RecordForID(spellID);
     return rec != nullptr &&
            (*reinterpret_cast<const uint32_t *>(rec + Offsets::OFF_SPELL_RECORD_ATTRIBUTES_EX) &
-            SPELL_ATTR_EX_CHANNELED) != 0;
+            Offsets::SPELL_ATTR_EX_CHANNELED) != 0;
 }
 
 int NowMs() {

src/spell/Info.cpp

@@ -22,9 +22,6 @@
 
 namespace Spell::Info {
 
-// Attributes (+0x18) bit 6 = SPELL_ATTR_PASSIVE — passive spell (no cast
-// bar, applies its effect as soon as learned/equipped).
-static constexpr uint32_t SPELL_ATTR_PASSIVE = 0x40;
 // GetSpellInfo's isFunnel means a health-funnel spell — AttributesEx2 (+0x20)
 // bit 11 = SPELL_ATTR_EX2_HEALTH_FUNNEL. Verified from Spell.dbc: Health
 // Funnel (755) Ex2=0x808 and Hellfire (1949) Ex2=0x800 carry it, while
@@ -397,7 +394,7 @@ static int PushIsPassive(void *L, int spellID) {
         return 0;
     const uint32_t attr = *reinterpret_cast<const uint32_t *>(
         record + Offsets::OFF_SPELL_RECORD_ATTRIBUTES);
-    Game::Lua::PushBool(L, (attr & SPELL_ATTR_PASSIVE) != 0);
+    Game::Lua::PushBool(L, (attr & Offsets::SPELL_ATTR_PASSIVE) != 0);
     return 1;
 }
 

src/spell/Level.cpp

@@ -130,7 +130,6 @@ bool SpellHiddenFromSpellbook(int spellID) {
 // checks are NOT in the 1.12 client's Spell.dbc — server-only columns — so
 // the spellLevel rule is the only client-readable target-level mechanism.)
 
-constexpr uint32_t SPELL_ATTR_PASSIVE = 0x40;                    // Attributes bit
 constexpr uint32_t SPELL_EFFECT_APPLY_AURA = 6;
 constexpr uint32_t SPELL_EFFECT_APPLY_AREA_AURA_PARTY = 35;
 
@@ -184,7 +183,7 @@ int RequiredTargetLevel(const uint8_t *record) {
         return 0;
     const uint32_t attr =
         *reinterpret_cast<const uint32_t *>(record + Offsets::OFF_SPELL_RECORD_ATTRIBUTES);
-    if (attr & SPELL_ATTR_PASSIVE)
+    if (attr & Offsets::SPELL_ATTR_PASSIVE)
         return 0;
     if (!HasRankString(record)) // single-rank spell → not gated
         return 0;