Repository navigation
[APS-21171][APS-20636] bump jackson-core/databind to 2.18.9 - #87
Open
jasbir-browserstack wants to merge 1 commit into
Open
jasbir-browserstack wants to merge 1 commit into
jasbir-browserstack wants to merge 1 commit into
Conversation
Single property bump closes both CVEs in one change: * APS-21171 — jackson-core async parser maxNumberLength bypass (GHSA-r7wm-3cxj-wff9, incomplete fix for GHSA-72hv-8253-57qq). Fixed in jackson-core 2.18.8; 2.18.9 inherits the fix. * APS-20636 — jackson-databind BasicPolymorphicTypeValidator allowIfSubTypeIsArray allowlist bypass (GHSA-rmj7-2vxq-3g9f, CVSS 8.1). Fixed in jackson-databind 2.18.8; 2.18.9 inherits. jackson-core and jackson-databind share one <jackson.version> property in pom.xml, so one line bump covers both. Supersedes Dependabot PRs browserstack#85 and browserstack#86 (which each only bumped one of the two).
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Single one-line bump of the shared
<jackson.version>property inpom.xml(2.18.6 → 2.18.9) closes two open P2 Jackson CVEs together:jackson-coreasync parsermaxNumberLengthbypass via chunked digit accumulation (GHSA-r7wm-3cxj-wff9, incomplete fix for GHSA-72hv-8253-57qq). Fixed injackson-core2.18.8; 2.18.9 inherits.jackson-databindBasicPolymorphicTypeValidator.allowIfSubTypeIsArray()allowlist bypass (GHSA-rmj7-2vxq-3g9f, CVSS 8.1). Fixed injackson-databind2.18.8; 2.18.9 inherits.Why one PR, not the two open Dependabot PRs
pom.xmldeclares bothjackson-coreandjackson-databindvia a single shared<jackson.version>property:Dependabot PRs #85 (databind) and #86 (core) each only bump one of the two literal version strings without touching the shared property, which would leave one of core/databind pinned at the stale
${jackson.version}= 2.18.6. The clean fix is to bump the property; keepsjackson-coreandjackson-databindin lockstep (Jackson maintainers' recommended practice — mismatched versions produceNoSuchMethodErrorat runtime).Please close #85 and #86 as superseded if this PR is merged.
Test plan
mvn verifypasses on the branchObjectMapper.readValueonly (verified: 0 hits forNonBlocking*,PolymorphicTypeValidator,allowIfSubTypeIsArray), so neither vulnerable code path is exercised by this client — but shipping the fix also protects downstream consumers who may use those APIs on top of our artifact.