made target text optional so we can use fallback#138
Merged
sauravpanda merged 2 commits intoNov 7, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
1 issue found across 2 files
Prompt for AI agents (all 1 issues)
Understand the root cause of the following 1 issues and fix them.
<file name=".github/workflows/publish.yml">
<violation number="1" location=".github/workflows/publish.yml:50">
Hard-coding the checkout to the main branch means this release workflow will publish whatever is on main rather than the commit associated with the release tag, so releases created from other branches or older commits will produce incorrect artifacts.</violation>
</file>
React with 👍 or 👎 to teach cubic. Mention @cubic-dev-ai to give feedback, ask questions, or re-run the review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by cubic
Allow target_text to be optional in SelectorWorkflowSteps so fallback selector strategies are used when text is missing. Update the publish workflow to check out the release tag commit and remove the step that pushes a temporary stable branch.
Written for commit 7b6346f. Summary will update automatically on new commits.