Skip to content

made target text optional so we can use fallback#138

Merged
sauravpanda merged 2 commits into
mainfrom
136-allow-null-value-for-target-text-so-that-it-can-use-fallback-selector
Nov 7, 2025
Merged

made target text optional so we can use fallback#138
sauravpanda merged 2 commits into
mainfrom
136-allow-null-value-for-target-text-so-that-it-can-use-fallback-selector

Conversation

@sauravpanda
Copy link
Copy Markdown
Collaborator

@sauravpanda sauravpanda commented Nov 6, 2025

Summary by cubic

Allow target_text to be optional in SelectorWorkflowSteps so fallback selector strategies are used when text is missing. Update the publish workflow to check out the release tag commit and remove the step that pushes a temporary stable branch.

Written for commit 7b6346f. Summary will update automatically on new commits.

Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 2 files

Prompt for AI agents (all 1 issues)

Understand the root cause of the following 1 issues and fix them.


<file name=".github/workflows/publish.yml">

<violation number="1" location=".github/workflows/publish.yml:50">
Hard-coding the checkout to the main branch means this release workflow will publish whatever is on main rather than the commit associated with the release tag, so releases created from other branches or older commits will produce incorrect artifacts.</violation>
</file>

React with 👍 or 👎 to teach cubic. Mention @cubic-dev-ai to give feedback, ask questions, or re-run the review.

Comment thread .github/workflows/publish.yml Outdated
Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

@sauravpanda sauravpanda merged commit 3b525bf into main Nov 7, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

allow null value for target text so that it can use fallback selector

1 participant