fix: prevent duplicate character insertion in press_key() for contenteditable#346
Open
TheMapleBin wants to merge 1 commit into
Open
fix: prevent duplicate character insertion in press_key() for contenteditable#346TheMapleBin wants to merge 1 commit into
TheMapleBin wants to merge 1 commit into
Conversation
…editable press_key() was sending printable text through both keyDown(text=...) and char(text=...). For contenteditable elements, Chromium may insert text during both phases, causing each character to appear twice. This removes text from the keyDown event and keeps the char event as the only insertion-bearing event.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
press_key()currently sends text on bothkeyDownandcharCDP events.contenteditableelements.你好→你你好好.Fix
Remove
textfrom thekeyDownevent. Thecharevent, which immediately follows, remains the insertion-bearing event.This preserves the
keyDown/keyUppair for listeners that watch raw keyboard events while ensuring printable text is inserted only once.Test
Example case: