Document self-modifying Browser Harness workflow#334
Open
MagMueller wants to merge 2 commits into
Open
Conversation
✅ Skill review passedReviewed 1 file(s) — no findings. |
Contributor
Author
|
Worker verification pass (post-bench-docs):
Ready for review/merge from the docs side. Edge-case benchmark notes are owned by another worker. |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
1 issue found across 4 files (changes from recent commits).
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="docs/edge-case-benchmark.html">
<violation number="1" location="docs/edge-case-benchmark.html:261">
P2: The signature task listens to both pointer and mouse events unconditionally, which double-handles mouse input on Pointer Event browsers and can make stroke thresholds pass too easily.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review, or fix all with cubic.
| drawing = false; | ||
| if (pathLength > 120 && pointCount >= 5) mark("signature", "signature captured"); | ||
| } | ||
| signature.addEventListener("pointerdown", startSignature); |
Contributor
There was a problem hiding this comment.
P2: The signature task listens to both pointer and mouse events unconditionally, which double-handles mouse input on Pointer Event browsers and can make stroke thresholds pass too easily.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At docs/edge-case-benchmark.html, line 261:
<comment>The signature task listens to both pointer and mouse events unconditionally, which double-handles mouse input on Pointer Event browsers and can make stroke thresholds pass too easily.</comment>
<file context>
@@ -0,0 +1,294 @@
+ drawing = false;
+ if (pathLength > 120 && pointCount >= 5) mark("signature", "signature captured");
+ }
+ signature.addEventListener("pointerdown", startSignature);
+ signature.addEventListener("pointermove", moveSignature);
+ signature.addEventListener("pointerup", endSignature);
</file context>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
docs/self-modifying-harness.mdexplaining the self-modifying Browser Harness workflow for edge cases.docs/edge-case-benchmark.html, a local benchmark page covering file upload, drag/drop, signature canvas, and coordinate-only canvas targets.README.mdandSKILL.md.Validation
git diff --checkabout:blank; all four checks passed:Run notes
file://page directly, so the practical remote path isPage.setDocumentContent/ injecting the HTML intoabout:blank.data:navigation failed in remote Chrome withchrome-error://chromewebdata/; use document injection for this benchmark.wait_for_element, so the run used JS polling.scrollIntoView()before measuring coordinates; viewport scroll state matters for canvas tests.constredeclaration errors.