Skip to content

make sure rotate elts in the table (like roughnums!) don't punch through#622

Merged
blerner merged 2 commits intohorizonfrom
fix-thead-zindex
Apr 7, 2026
Merged

make sure rotate elts in the table (like roughnums!) don't punch through#622
blerner merged 2 commits intohorizonfrom
fix-thead-zindex

Conversation

@schanzer
Copy link
Copy Markdown
Contributor

No description provided.

@schanzer schanzer requested a review from jpolitz March 26, 2026 10:50
@blerner
Copy link
Copy Markdown
Member

blerner commented Apr 7, 2026

This works, and it's 95% complete -- there's a teeeny visual issue remaining, with the border of a scrolled thead element:
image

The side borders scroll up, and the top border scrolls away (because it's attached to the table, not the thead), leaving a 1px gap of weirdness...

… a lot smarter about our rounded corner borders
@schanzer
Copy link
Copy Markdown
Contributor Author

schanzer commented Apr 7, 2026

@blerner that issue is actually unrelated to the rotation thing -- it's just a part of using position:sticky. Anyway, I've fixed it in the latest commit.

@blerner
Copy link
Copy Markdown
Member

blerner commented Apr 7, 2026

Probably good enough :) there's still a silly little CSS glitch of the rounded-corners vs the side borders when scrolled, but I suspect it would take way too much time to finesse:
image

The right solution would be to use https://developer.mozilla.org/en-US/docs/Web/CSS/Guides/Conditional_rules/Container_scroll-state_queries, and the CSS from https://stackoverflow.com/a/57991537, and use that to unround the corners... but Firefox doesn't support scroll-state queries yet :(

@blerner blerner merged commit 0b5fd83 into horizon Apr 7, 2026
2 checks passed
@blerner blerner deleted the fix-thead-zindex branch April 7, 2026 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants