ci(release): sync ui-concepts/ → data/ before buildfs so releases ship the latest UI - #37
Merged
Merged
Conversation
…mage The release build packaged web assets from the committed data/, but the UI source of truth is ui-concepts/ (synced via scripts/sync_web.py, a manual step that was easy to forget — so a release could ship a stale UI). Run the sync in CI before buildfs so every release always carries the latest UI regardless of what's committed in data/. .gz are gitignored and regenerated by the buildfs gzip pre-hook, so no committed artifacts drift. The tag-to-release trigger is unchanged: cutting a release stays a deliberate human action; only the sync is automated. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
Automates regeneration of device-served web assets during the release workflow so OTA/LittleFS images always include the UI sources from ui-concepts/ at the tagged commit, removing the manual “sync before release” step.
Changes:
- Adds a
python3 scripts/sync_web.pystep to the release workflow. - Ensures the sync runs before per-board
pio run ... -t buildfs, so the LittleFS image is built from freshly regenerateddata/.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The OTA release build packages web assets from the committed
data/, but the UI source of truth isui-concepts/(copied intodata/byscripts/sync_web.py— a manual step). If someone edits the UI and forgets to sync, a tagged release ships a stale UI. (This just bit us: the modular-panels/theming UI merged in #36 lives inui-concepts/butdata/was never re-synced.)Fix
Run
scripts/sync_web.pyinrelease.ymlbefore the per-boardbuildfsstep, so the LittleFS image always reflects the latestui-concepts/at the tagged commit..gzare gitignored and regenerated by thebuildfsgzip pre-hook, so nothing drifts.Deliberately unchanged
The tag-to-release trigger stays manual — cutting a release is still a deliberate human action (you don't want every merge auto-flashing field devices). Only the sync is automated.
Verified
Ran
python3 scripts/sync_web.pylocally: regeneratesdata/correctly (new modular UI + Space Grotesk present). YAML validated.Follow-up (parked, not in this PR): rename
ui-concepts/→ it's production source now, not "concepts" — per architecture notes.🤖 Generated with Claude Code