Repository navigation
Conversation
…nd generation offline, built from the release with a patch for the missing return that crashed modern builds Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… network Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
tools/igor: IGoR 1.4.0 (the last release), built from the checksummed release archive on Debian bookworm, with its published human TRA/TRB/IGH/IGK/IGL and mouse TRB models in the image. CPU only, no network.Why it is patched. As released, IGoR 1.4.0 segfaults when built by GCC 8 or later:
Matrix::operator=inUtils.hhas noreturn *this(upstream issue #62, PR #67, never merged), and optimized builds turn that into a crash during generation and inference.igor-1.4.0.patchadds that return; adds a second missing one inDeletion::has_effect_on(the build now uses-Werror=return-type, which flagged it); stops three FASTA and sequence readers from reading before the start of an empty line (an ASan heap overflow); and makes two changes 1.4.0 needs to compile on a current GCC. It changes no model or algorithm.Test (
results/igor/1.0.0.txt, podman,--network none, 48 s on two threads):For the reviewer: the patch is small enough to read in full. The skill documents that IGoR exits 0 and writes nothing when
-set_wddoes not exist. GPLv3: the license, the release archive, and the patch are in the image at/usr/local/share/igor/source.🤖 Generated with Claude Code