Repository navigation
Optional metadata.count and metadata.unit in each dataset's skill - #21
Merged
Merged
Conversation
flyloft's Datasets page shows a dataset's entry count when its skill names one. Two optional frontmatter fields, together: count (digits only) and unit (what an entry is). - check.py: count is digits, and count and unit come together. - changed-datasets: a change only to count/unit lines is not a change, so adding them to a published version needs no new version. - A unit test runs the rules on every dataset, so a count-only edit is still checked. - Every existing skill gets its count, from its skill or record. - CONTRIBUTING, AGENTS, DESIGN: the fields and the version exception. Closes #20 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #20. flyloft's Datasets page (brineylab/flyloft#303) shows each dataset's entry count when the skill names it; this adds the fields here.
Fields: optional, together, under
metadata:count(the version's whole number of entries, digits only) andunit(what an entry is).No version bumps.
scripts/changed-datasetsnow diffs with-I '^ (count|unit):', so a change only to those lines isn't a dataset change and CI doesn't runcheck --hubon it (which would fail on the already-published tag). Any other edit to the skill still counts. The rest of the version rule is unchanged; CONTRIBUTING, AGENTS, and DESIGN state the exception.Checks:
check.pyrefuses a non-digitcountand acountwithoutunit(or the reverse). A new unit test runsrules()on every dataset, so count-only edits are still checked in CI.Counts (from each skill or its record):
Worth a look in review:
python3 -I -m unittest discover tests: OK.🤖 Generated with Claude Code