Fix stale Checkov runner state between scans - #62
Open
rnehoroshev wants to merge 1 commit into
Open
rnehoroshev wants to merge 1 commit into
rnehoroshev wants to merge 1 commit into
Conversation
Checkov shallow-copies its module-level runner instances, allowing mutable scan state to leak between admission requests. Instantiate fresh runners for each CheckovWhorf instance and add regression coverage for consecutive scans.
Author
|
@Saarett Could you review please? This is a critical fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CheckovWhorfinstanceupload_resultsoverride with Checkov's current signatureProblem
Checkov.__init__shallow-copies a module-level list of instantiated runners. Some runners retain mutable scan state, so a later admission request can process manifest data left behind by an earlier request.Solution
Replace the shallow-copied runners with newly constructed instances whenever Whorf creates a Checkov scanner.